Add blank avatar placeholder. Precache on startup for performance#54
Open
jordanmlacalle wants to merge 1 commit intoKide-Devs:masterfrom
Open
Add blank avatar placeholder. Precache on startup for performance#54jordanmlacalle wants to merge 1 commit intoKide-Devs:masterfrom
jordanmlacalle wants to merge 1 commit intoKide-Devs:masterfrom
Conversation
Cryptonex7
approved these changes
Oct 21, 2020
Member
Cryptonex7
left a comment
Cryptonex7
left a comment
There was a problem hiding this comment.
This looks great! @jordanmlacalle
As soon as @A4K9 approves this PR - We can merge this.
But since we have already released Kide v2.2.4 and its in review on the play store, we will have to push this as a patch to v2.2.5 - ETA would be 2 weeks from today.
vanshBhatia-A4k9
approved these changes
Oct 22, 2020
Collaborator
vanshBhatia-A4k9
left a comment
vanshBhatia-A4k9
left a comment
There was a problem hiding this comment.
Built and tested, works great! 👍
Collaborator
|
@Cryptonex7, please confirm & merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #39
Added a new SVG file with a blank avatar depiction. This avatar is precached on app startup so it can be immediately displayed in the menu while the user's customized avatar is being fetched. A CircularProgressIndicator is displayed behind the blank avatar to indicate loading.
This has only been tested on a Pixel 2 device.