Add CSS class name prefix to prevent conflicting styles when using SVG mode#4
Open
glennsayers wants to merge 1 commit intoKilianB:masterfrom
Open
Add CSS class name prefix to prevent conflicting styles when using SVG mode#4glennsayers wants to merge 1 commit intoKilianB:masterfrom
glennsayers wants to merge 1 commit intoKilianB:masterfrom
Conversation
Owner
|
Thank you. I'll check it out on Monday and will merge it |
|
@KilianB do you still maintain this repo? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @KilianB
Thanks for maintaining this fork - it's been of great use in one of my projects.
I have a use case where I need multiple SVG based QR codes on one page. Currently, due to the inline SVG styles not being uniquely named, I cannot have these QR codes be different colours.
I've added a row of SVG codes to the bottom of demo page to show this - note how they all inherit the colour of the last QR code:
To fix this, I've created a small function that will generate a random character string, and prefix this to the CSS classes on a per QR code basis. This makes the styles unique and prevents clashes.
See the same demo with this change added:
Thanks!