fix(code-review): clean up review DOs#3194
Open
alex-alecu wants to merge 6 commits into
Open
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Previously Reported IssuesBoth warnings from the initial review have been addressed in subsequent commits:
Files Reviewed (3 files, incremental)
Reviewed by claude-sonnet-4.6 · 1,475,544 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Some code review jobs could get stuck keeping old storage forever. This made unused data stay around when the review was already done or could no longer make progress.
What changed
Code reviews now keep a future alarm while they are waiting, running, or retrying after a short problem. Queued reviews fail after a safe wait instead of retrying forever. Running reviews check whether the main app already marked them done, and they fail after a long timeout if no final callback arrives. Finished reviews now check that the main app is done too before deleting their stored data.
How to test
pnpm --filter kilo-code-review-worker test.pnpm --filter kilo-code-review-worker typecheck.