fix(code-reviews): disable interactive tools#3272
Open
alex-alecu wants to merge 4 commits into
Open
Conversation
alex-alecu
force-pushed
the
fix/code-review-non-interactive
branch
from
3b5b9ec to
22fc2e2
Compare
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryAll three previously-flagged issues have been resolved: Resolved Issues (3)
Files Reviewed (5 files)
Reviewed by claude-sonnet-4.6 · 182,580 tokens Review guidance: REVIEW.md from base branch |
alex-alecu
commented
May 15, 2026
alex-alecu
commented
May 15, 2026
alex-alecu
commented
May 15, 2026
jrf0110
approved these changes
May 15, 2026
eshurakov
reviewed
May 15, 2026
Comment on lines
+233
to
+239
| const codeReviewJob = isCodeReviewJob(state); | ||
| const skipStatusForCodeReview = codeReviewJob && isInteractiveStatusType(sessionStatus.type); | ||
|
|
||
| if (codeReviewJob) { | ||
| rejectCodeReviewQuestion(pendingQuestion?.id, config.kiloClient); | ||
| rejectCodeReviewPermission(pendingPermission?.id, config.kiloClient); | ||
| } |
Contributor
There was a problem hiding this comment.
I don't think we should be doing that in the snapshot as it is a non mutable "getter"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Code reviews could get stuck when the agent asked a question that no one could answer. A review should keep moving without waiting for chat input.
What changed
Code-review runs now start without the tools that let the agent ask questions or enter planning mode. If a question or permission request still shows up, the wrapper rejects it and does not treat it like healthy activity. Normal cloud-agent sessions still keep their current interactive behavior. Tests cover new prompts, live events, and reconnect snapshots.
How to test
pnpm --filter cloud-agent-next test src/execution/orchestrator.test.ts test/unit/wrapper/snapshot.test.ts test/unit/wrapper/reconnection.test.ts.pnpm --filter cloud-agent-next typecheck.