feat: Display model + tokens in PR code reviews summary#407
Open
alex-alecu wants to merge 6 commits intomainfrom
Open
feat: Display model + tokens in PR code reviews summary#407alex-alecu wants to merge 6 commits intomainfrom
alex-alecu wants to merge 6 commits intomainfrom
Conversation
![kiloconnect[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (13 files)
|
…usage data Use 3 retries with 200/400/800ms delays instead of a single 2-second sleep. Reduces average latency when data is already present and provides more attempts when it isn't.
Cover buildUsageFooter and appendUsageFooter including first-time append, footer replacement with exact and variant whitespace, empty body, unrelated horizontal rules, and multi-slash model slugs.
Sync model/token/cost accumulators to this.state on every LLM API event so they are written to durable storage by the existing event batch save. Restore them in loadState() so accumulation resumes correctly after a DO restart.
| // We pass the current status (no status change) to just update the usage fields. | ||
| const status = CodeReviewStatusSchema.parse(review.status); | ||
|
|
||
| await updateCodeReviewStatus(reviewId, status, { |
Contributor
There was a problem hiding this comment.
[WARNING]: updateCodeReviewStatus will overwrite started_at timestamp
When this endpoint is called while the review is in 'running' status, updateCodeReviewStatus auto-sets started_at = new Date() (in code-reviews.ts line 129) because updates.startedAt is undefined. This silently overwrites the original started_at with the current time, making the review appear to have started much later than it actually did.
Consider either:
- Passing
startedAt: review.started_at ? new Date(review.started_at) : undefinedto preserve the existing value, or - Adding a dedicated
updateCodeReviewUsage()function that only updates usage fields without touching status/timestamps.
|
|
||
| // Restore usage accumulators from persisted state so they survive DO eviction | ||
| if (storedState.model) this.model = storedState.model; | ||
| if (storedState.totalTokensIn) this.totalTokensIn = storedState.totalTokensIn; |
Contributor
There was a problem hiding this comment.
[WARNING]: Truthiness check fails for 0 — fragile restore logic
if (storedState.totalTokensIn) evaluates to false when the value is 0. Currently benign because the class fields default to 0, but this is fragile: if defaults change or if the intent is to explicitly restore a persisted 0, this silently skips the assignment.
Prefer explicit nullish checks:
Suggested change
| if (storedState.totalTokensIn) this.totalTokensIn = storedState.totalTokensIn; | |
| if (storedState.totalTokensIn != null) this.totalTokensIn = storedState.totalTokensIn; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We cannot include the total tokens in the first summary because we would exclude the tokens used to generate the token itself. Instead we manually add the footer after the summary is posted.