fix(session-ingest): exclude session_diff items from ingest getAll#423
Merged
fix(session-ingest): exclude session_diff items from ingest getAll#423
Conversation
these are often very large and cause oom/serialization issues
pandemicsyn
approved these changes
Feb 20, 2026
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (1 file)
|
There was a problem hiding this comment.
Pull request overview
This PR fixes OOM and serialization issues in the session ingestion system by excluding large session_diff items from the getAll() query results.
Changes:
- Modified the SQL query in
SessionIngestDO.getAll()to filter out items withitem_type = 'session_diff'
Comments suppressed due to low confidence (1)
cloudflare-session-ingest/src/dos/SessionIngestDO.ts:216
- The SQL string uses double quotes, which is inconsistent with the rest of the file. Other SQL exec calls in this file and in SessionAccessCacheDO.ts use either single quotes or backticks. For consistency with the existing codebase, consider using single quotes or backticks for the SQL string.
"SELECT item_id, item_type, item_data FROM ingest_items WHERE item_type != 'session_diff' ORDER BY id"
)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
these are often very large and cause oom/serialization issues