Skip to content

Comments

fix(session-ingest): exclude session_diff items from ingest getAll#423

Merged
iscekic merged 3 commits intomainfrom
skip-session-diff-items
Feb 20, 2026
Merged

fix(session-ingest): exclude session_diff items from ingest getAll#423
iscekic merged 3 commits intomainfrom
skip-session-diff-items

Conversation

@iscekic
Copy link
Contributor

@iscekic iscekic commented Feb 20, 2026

these are often very large and cause oom/serialization issues

these are often very large and cause oom/serialization issues
@kiloconnect
Copy link
Contributor

kiloconnect bot commented Feb 20, 2026

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
cloudflare-session-ingest/src/dos/SessionIngestDO.ts 265 SQL query selects item_id but the TypeScript type generic doesn't declare it — mismatch between query and type annotation
Files Reviewed (1 file)
  • cloudflare-session-ingest/src/dos/SessionIngestDO.ts - 1 issue

Fix these issues in Kilo Cloud

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes OOM and serialization issues in the session ingestion system by excluding large session_diff items from the getAll() query results.

Changes:

  • Modified the SQL query in SessionIngestDO.getAll() to filter out items with item_type = 'session_diff'
Comments suppressed due to low confidence (1)

cloudflare-session-ingest/src/dos/SessionIngestDO.ts:216

  • The SQL string uses double quotes, which is inconsistent with the rest of the file. Other SQL exec calls in this file and in SessionAccessCacheDO.ts use either single quotes or backticks. For consistency with the existing codebase, consider using single quotes or backticks for the SQL string.
        "SELECT item_id, item_type, item_data FROM ingest_items WHERE item_type != 'session_diff' ORDER BY id"
      )

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@iscekic iscekic merged commit 14f5eea into main Feb 20, 2026
12 checks passed
@iscekic iscekic deleted the skip-session-diff-items branch February 20, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants