Conversation
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
| customBorderChars={{ | ||
| ...EmptyBorder, | ||
| vertical: theme.backgroundElement.a !== 0 ? "╹" : " ", | ||
| // kilocode_change start - render only the seam half in the final row for a 4.5-cell rail |
There was a problem hiding this comment.
WARNING: Removed alpha-transparency conditional may cause visual regression
The old code was:
vertical: theme.backgroundElement.a !== 0 ? "╹" : " ",This conditionally hid the glyph when the background element was fully transparent (a === 0). The new code always renders "╹" regardless of alpha.
Notably, the sibling <box> element just below (around line 1048-1057 in the base) still uses the same theme.backgroundElement.a !== 0 conditional to decide between horizontal: "▀" and horizontal: " ". This creates an inconsistency: when the theme has a transparent background element, the horizontal border will be hidden but the vertical rail glyph will still render.
Was this intentional? If so, please confirm. If not, consider preserving the conditional:
vertical: theme.backgroundElement.a !== 0 ? "╹" : " ",
Code Review SummaryStatus: No New Issues Found | Recommendation: Merge (after addressing existing comment) OverviewThis PR makes two small cosmetic changes to the TUI prompt border characters in
No security, logic, or runtime issues were identified beyond the existing inline comment. Files Reviewed (1 file)
|
|
@aravhawk is attempting to deploy a commit to the Kilo Code Team on Vercel. A member of the Team first needs to authorize it. |
Context
Fixes a TUI rendering bug where the vertical bar next to the prompt/agent row is partially cut off in small terminals (for example
80x24in Terminal.app).Closes #438.
Implementation
Updated prompt border glyph rendering in
/Users/aravhawk/kilo/packages/opencode/src/cli/cmd/tui/component/prompt/index.tsxto keep the rail visually continuous in compact terminal sizes:┃) through the seam.╹) to render the intended “4.5-cell” tail instead of a clipped or detached full segment.Screenshots
How to Test
80x24).kilocd /Users/aravhawk/kilo && bun run devGet in Touch
Discord:
@aravhawk