fix(ui): remove redundant copy button from TextPartDisplay#453
Open
haliliceylan wants to merge 3 commits intoKilo-Org:devfrom
Open
fix(ui): remove redundant copy button from TextPartDisplay#453haliliceylan wants to merge 3 commits intoKilo-Org:devfrom
haliliceylan wants to merge 3 commits intoKilo-Org:devfrom
Conversation
|
@haliliceylan is attempting to deploy a commit to the Kilo Code Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Clean removal of the redundant copy button from What was verified:
Files Reviewed (2 files)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
fixes #445
The TextPartDisplay component in
packages/ui/src/components/message-part.tsxhad a copy button that copied the entire part.text content (raw markdown source). This was redundant and confusing because the Markdown component already provides copy buttons for individual code blocks.Users clicking "copy" near a code block would sometimes get the raw markdown source (including extra text, formatting markers) instead of just the code content, depending on which copy button they clicked.
flowchart LR subgraph UI["packages/ui"] MP[message-part.tsx] MP -->|PART_MAPPING.text| TPD[TextPartDisplay] TPD -->|contains| MD[Markdown] TPD -->|contains| CPY[Copy Button] end style CPY fill:#ff6b6b,color:whiteImplementation
Removed the redundant copy functionality from TextPartDisplay
Screenshots
How to Test
from original issue
Get in Touch
https://discord.com/channels/1349288496988160052/1391109167275577464/1473821631267995872