feat(cli): add roll-call command for batch-testing model connectivity#463
feat(cli): add roll-call command for batch-testing model connectivity#463cbrunnkvist wants to merge 1 commit intoKilo-Org:devfrom
Conversation
|
@cbrunnkvist is attempting to deploy a commit to the Kilo Code Team on Vercel. A member of the Team first needs to authorize it. |
a8337fd to
adb9f5d
Compare
26183e0 to
21f6738
Compare
21f6738 to
edafafb
Compare
733b6c7 to
886c3bb
Compare
| .option("retries", { | ||
| type: "number", | ||
| default: 0, | ||
| describe: "Number of additional retries for each model call", |
There was a problem hiding this comment.
WARNING: The retries option is defined here but never used in the handler.
On line 129, the destructuring const { prompt, timeout, filter, parallel, output, verbose, quiet } = args omits retries, and no retry logic exists in processModel. Users passing --retries 3 would expect failed model calls to be retried, but the flag silently does nothing.
Either implement retry logic in processModel or remove this option to avoid misleading users.
| @@ -0,0 +1,298 @@ | |||
| import type { Argv } from "yargs" | |||
There was a problem hiding this comment.
SUGGESTION: Missing kilocode_change - new file marker.
Per AGENTS.md, new files outside of kilocode-named directories should have a // kilocode_change - new file comment at the top to help identify Kilo-specific additions during upstream merges. The test file has this marker but the source file does not.
| import type { Argv } from "yargs" | |
| // kilocode_change - new file | |
| import type { Argv } from "yargs" |
| import { UpgradeCommand } from "./cli/cmd/upgrade" | ||
| import { UninstallCommand } from "./cli/cmd/uninstall" | ||
| import { ModelsCommand } from "./cli/cmd/models" | ||
| import { RollCallCommand } from "./cli/cmd/roll-call" |
There was a problem hiding this comment.
SUGGESTION: Missing kilocode_change marker on this new import.
Per AGENTS.md, modifications to shared upstream files should be marked with kilocode_change comments so they can be easily identified during merges.
| import { RollCallCommand } from "./cli/cmd/roll-call" | |
| import { RollCallCommand } from "./cli/cmd/roll-call" // kilocode_change |
| .command(ServeCommand) | ||
| .command(WebCommand) | ||
| .command(ModelsCommand) | ||
| .command(RollCallCommand) |
There was a problem hiding this comment.
SUGGESTION: Missing kilocode_change marker on this new command registration.
| .command(RollCallCommand) | |
| .command(RollCallCommand) // kilocode_change |
Code Review SummaryStatus: 4 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (3 files)
|
Summary
This PR adds a new
roll-callsubcommand that allows users to batch-test multiple models for connectivity and latency. This helps users discover which provider/model pairs are available and working.Features
Technical Details
The implementation:
ProviderTransformoptions (maxOutputTokens,temperature,topP,topK,providerOptions)Testing
Tested with various model filters:
Demonstrating truncation, error handling, color coding:
Related Issue
Closes #457