Rename yaml files to yml to fix i18n loading#27
Merged
KimNorgaard merged 2 commits intoKimNorgaard:mainfrom Apr 14, 2026
Merged
Rename yaml files to yml to fix i18n loading#27KimNorgaard merged 2 commits intoKimNorgaard:mainfrom
KimNorgaard merged 2 commits intoKimNorgaard:mainfrom
Conversation
Contributor
Author
|
ping @KimNorgaard |
Owner
Thanks. Seems like the tests are failing. Might want to take a look at that. |
Contributor
Author
|
Should be fixed, apologies for the inconvenience. |
KimNorgaard
approved these changes
Apr 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aligns the test I18n load path with the project’s .yml locale files so translations are actually loaded during specs.
Changes:
- Update
spec/spec_helper.rbto loadconfig/locales/*.yml(instead of*.yaml). - Add locale translation files under
config/locales/for several languages.
Reviewed changes
Copilot reviewed 1 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| spec/spec_helper.rb | Fixes the locale glob to match .yml, enabling I18n translations in specs. |
| config/locales/en.yml | Adds English error message translations for hostname validation. |
| config/locales/es.yml | Adds Spanish error message translations for hostname validation. |
| config/locales/fr.yml | Adds French error message translations for hostname validation. |
| config/locales/de.yml | Adds German error message translations for hostname validation. |
| config/locales/zh.yml | Adds Chinese error message translations for hostname validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
@adamzapasnik pushed 2.0.30 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the code doesn't load
yamlfiles because the regexp usesyml