Solution.from_preset: Update representative industrial wastewaters#362
Solution.from_preset: Update representative industrial wastewaters#362rkingsbury merged 6 commits intoKingsburyLab:mainfrom
Conversation
|
Note: CI is failing with the same error for the listed industries, while others are passing: |
|
Thanks @SuixiongTay , looks good except that the compositions should not have gotten more complex; they should have similar or fewer components compared to
Yes, that'll be due to Issue #335 . For now please comment out the offending presets and add a comment referencing the issue. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #362 +/- ##
=======================================
Coverage 86.10% 86.10%
=======================================
Files 14 14
Lines 1821 1821
Branches 313 313
=======================================
Hits 1568 1568
Misses 209 209
Partials 44 44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
This PR updates the industrial wastewaters to
Solution.from_preset. See (version 3) for the analysis supporting these compositions.ToDos
docstrings