Skip to content

Solution.from_preset: Update representative industrial wastewaters#362

Merged
rkingsbury merged 6 commits intoKingsburyLab:mainfrom
SuixiongTay:sync_presets
Mar 26, 2026
Merged

Solution.from_preset: Update representative industrial wastewaters#362
rkingsbury merged 6 commits intoKingsburyLab:mainfrom
SuixiongTay:sync_presets

Conversation

@SuixiongTay
Copy link
Collaborator

@SuixiongTay SuixiongTay commented Mar 20, 2026

Summary

This PR updates the industrial wastewaters to Solution.from_preset. See (version 3) for the analysis supporting these compositions.

ToDos

  • Update doc strings

@SuixiongTay
Copy link
Collaborator Author

Note: CI is failing with the same error for the listed industries, while others are passing:

ValueError: Cannot specify both a non-default pH and H+ at the same time. Please provide only one.
test_solution.py::test_from_preset[drilling] FAILED                                                                               [  4%]
test_solution.py::test_from_preset[FGD] FAILED                                                                                    [  4%]
test_solution.py::test_from_preset[gasification] FAILED                                                                           [  4%]
test_solution.py::test_from_preset[geothermal] FAILED                                                                             [  5%]
test_solution.py::test_from_preset[pw_conv] FAILED                                                                                [  5%]
test_solution.py::test_from_preset[pw_unconv] FAILED                                                                              [  5%]
test_solution.py::test_from_preset[refining] FAILED                                                                               [  5%]
test_solution.py::test_from_preset[smelting] PASSED                                                                               [  5%]
test_solution.py::test_from_preset[tanning] FAILED                                                                                [  6%]

@rkingsbury
Copy link
Member

Thanks @SuixiongTay , looks good except that the compositions should not have gotten more complex; they should have similar or fewer components compared to main. See my comment in the other repo.

Note: CI is failing with the same error for the listed industries, while others are passing:

Yes, that'll be due to Issue #335 . For now please comment out the offending presets and add a comment referencing the issue.

@codecov
Copy link

codecov bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.10%. Comparing base (804ed87) to head (e46444b).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #362   +/-   ##
=======================================
  Coverage   86.10%   86.10%           
=======================================
  Files          14       14           
  Lines        1821     1821           
  Branches      313      313           
=======================================
  Hits         1568     1568           
  Misses        209      209           
  Partials       44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rkingsbury rkingsbury merged commit b32da26 into KingsburyLab:main Mar 26, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants