Fix dtype handling in attention masks#28
Open
ray24777 wants to merge 1 commit intoKiteretsu77:mainfrom
Open
Conversation
Fix a bug when using DAT models at fp16 precision infer
Author
|
Hey @Kiteretsu77 , would you please review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix RuntimeError during DAT model FP16 inference
Description
This PR fixes a bug where using DAT models with half-precision (fp16) inference would crash due to a data type mismatch.
Fixes #29 .
The Issue
When running inference with
weight_dtype=torch.float16, the dynamically generated attention mask inAdaptive_Spatial_Attentionremained infloat32(default), while the input tensorvwas infloat16. This caused aRuntimeErrorduring the matrix multiplication operation (attn @ v).Error Log
Solution
Modified the
forwardmethod inAdaptive_Spatial_Attention, specifically wheremask_tmpis handled, to explicitly cast the generated mask to the input tensor'sdtype. This ensures compatibility regardless of whether the model is running in full or half precision.