ci: modernize packaging and release to trusted publishing#6
Open
jlee-kitware wants to merge 4 commits into
Open
ci: modernize packaging and release to trusted publishing#6jlee-kitware wants to merge 4 commits into
jlee-kitware wants to merge 4 commits into
Conversation
Replace setup.cfg/setup.py with a hatchling pyproject.toml, and switch the release workflow to python-semantic-release v10 + PyPI trusted publishing (OIDC), matching the trame-cookiecutter baseline. Keeps the flat layout and force-includes the built vue-components bundle via hatch artifacts.
jourdain
reviewed
Jun 16, 2026
| ] | ||
|
|
||
| [tool.hatch.build.targets.wheel] | ||
| packages = ["trame_code", "trame"] |
Collaborator
There was a problem hiding this comment.
could you move those 2 directories under ./src?
Collaborator
There was a problem hiding this comment.
You will also need to update that path
https://github.com/Kitware/trame-code/blob/master/vue-components/vite.config.ts#L23
flake8 4.0.1 crashes on Python 3.12 (importlib.metadata entry_points no longer has .get); 7.3.0 runs clean against the existing .flake8 config.
Collaborator
|
Normally we are not using flake anymore. Just ruff. |
Adopt the src/ layout per review. Update hatch packages/artifacts paths and the vite build outDir accordingly. Wheel still maps to top-level trame_code and the trame namespace shim, with the built bundle force-included.
Replace flake8/black with the cookiecutter pre-commit set (ruff + ruff-format, prettier, codespell, standard hooks) and add the ruff config to pyproject with targeted per-file-ignores for the trame namespace shims, tests, and examples. Remove .flake8. Includes the resulting ruff-format/prettier reformatting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace setup.cfg/setup.py with a hatchling pyproject.toml, and switch the release workflow to python-semantic-release v10 + PyPI trusted publishing (OIDC), matching the trame-cookiecutter baseline. Keeps the flat layout and force-includes the built vue-components bundle via hatch artifacts.