ci: fix failing deployment by updating the github workflow from cookiecutter's#119
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic deployment failed on last merge: https://github.com/Kitware/trame-vtk/actions/runs/26819578811/job/79070621138 because the PR #108 uses
uvand the github workflow wasn't updated to install it.imagedata_serializerfunction must haverequested_fieldsas an optional argument with a default value (I broke that in my last PR Maintenance pre-commit and picture #108)uv, the github workflow wasn't updated with the cookiecutter's one souvwas not installed.Here is the diff between the proposed .github/workflows/test_and_release.yml here and the cookiecutter's one (modulo some spaces/line breaks).