Skip to content

fix: revert pre-commit change on static_viewer.html#121

Closed
Jo-Byr wants to merge 1 commit into
masterfrom
120-revert-static_viewer-change
Closed

fix: revert pre-commit change on static_viewer.html#121
Jo-Byr wants to merge 1 commit into
masterfrom
120-revert-static_viewer-change

Conversation

@Jo-Byr

@Jo-Byr Jo-Byr commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Revert static_viewer.html introduced in 0d7fb06

Should fix #120

@Jo-Byr Jo-Byr requested a review from jourdain June 10, 2026 09:30
@UlysseDurand

Copy link
Copy Markdown
Contributor

Maybe the .externals.sha256 file's line for the static_viewer should also be reverted
Same for the url in .fetch_externals.sh

The github workflow contains

      # -----------------------------------------------------------------------
      # Make that step a manual one and pushing files to the repo
      # -----------------------------------------------------------------------
      # - name: Install trame-vtk.js
      #   run: |
      #     bash .fetch_externals.sh
      # -----------------------------------------------------------------------

@jourdain

Copy link
Copy Markdown
Collaborator

So before, that fetch was automatic. Now we want to make it manual to make sure we don't brake the viewer (while still using the scripts).
Ideally, it should be integrated into the CI.

Were the url and sha updated with your edits?

@Jo-Byr Jo-Byr closed this Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PyVista broken with 2.11.9

3 participants