Skip to content

Fix import error in C++ example #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jspanchu merged 2 commits into from
Mar 30, 2026
Merged

Fix import error in C++ example #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27a3307
chore: bump min emsdk version in readme
jspanchu Mar 28, 2026
a2f3198
chore: import manual registrar func only when vtk < 9.5.20250920
jspanchu Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ Optionally, you can develop with bleeding edge VTK by following these steps. Mak
3. Ninja
4. Python
5. NodeJS >= 24.0.1: https://nodejs.org/en/download/package-manager
6. Emscripten SDK version 4.0.10: See https://emscripten.org/docs/getting_started/downloads.html#download-and-install
6. Emscripten SDK version 4.0.20: See https://emscripten.org/docs/getting_started/downloads.html#download-and-install

.. code-block:: console

Expand Down
17 changes: 15 additions & 2 deletions examples/cpp/highlight_picked_actor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,27 @@
import vtk
from addonModules.addonStyle import (
HighlightPickedActorStyle,
RegisterClasses_addonStyle,
) # type: ignore

from trame.app import get_server
from trame.ui.html import DivLayout
from trame.widgets import html, client, vtklocal
from trame.decorators import TrameApp

VTK_VERSION = vtk.vtkVersion()
# needed for vtk < 9.5.20250920
MANUAL_SERDES_REGISTRATION_NEEDED = (
VTK_VERSION.GetVTKMajorVersion() <= 9
and VTK_VERSION.GetVTKMinorVersion() <= 5
and VTK_VERSION.GetVTKBuildVersion() < 20250920
) # https://gitlab.kitware.com/vtk/vtk/-/merge_requests/12426

addon_serdes_registrars = []
if MANUAL_SERDES_REGISTRATION_NEEDED:
from addonModules.addonStyle import RegisterClasses_addonStyle # noqa: E402

addon_serdes_registrars.append(RegisterClasses_addonStyle)

FULL_SCREEN = "position:absolute; left:0; top:0; width:100vw; height:100vh;"
TOP_RIGHT = "position: absolute; top: 1rem; right: 1rem; z-index: 10;"
TOP_LEFT = "position: absolute; top: 1rem; left: 1rem; z-index: 10;"
Expand Down Expand Up @@ -110,7 +123,7 @@ def _build_ui(self):
with html.Div(style=FULL_SCREEN):
with vtklocal.LocalView(
self.render_window,
addon_serdes_registrars=[RegisterClasses_addonStyle],
addon_serdes_registrars=addon_serdes_registrars,
wasm_dir=WASM_DIR,
wasm_base_name=WASM_BASE_NAME,
) as view:
Expand Down
Loading