[WIP] Add a dictionary for DICOM metadata to DICOMImage class#4
Open
zachmullen wants to merge 7 commits intomainfrom
Open
[WIP] Add a dictionary for DICOM metadata to DICOMImage class#4zachmullen wants to merge 7 commits intomainfrom
zachmullen wants to merge 7 commits intomainfrom
Conversation
| template< typename TPixel, unsigned int VImageDimension > | ||
| MetaDataDictionary & | ||
| DICOMImage< TPixel, VImageDimension > | ||
| ::GetDICOMMetaData(void) |
Collaborator
There was a problem hiding this comment.
Per modern style we omit the "void"
Collaborator
|
Cool. This a good start. We could change the data structure later if we find a more specific one is beneficial. Please add tests for the new methods. |
| { | ||
| /** \class DICOMImageIO | ||
| * | ||
| * \brief Read DICOM image file format. |
Collaborator
There was a problem hiding this comment.
To fix the failing test, add
\ingroup DICOM
here.
Collaborator
|
Looking good! |
Contributor
Author
|
Given the time crunch, this turned into a really rudimentary prototype for testing file-based anonymization using profiles. That basic aspect is demonstrated in the test, though it's still a far cry from the feature-completeness that CTP provides with their profiles. |
Collaborator
|
+1 for rapid, agile development that plants incremental flags in usefulness. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.