Fix "Create task" button showing over "Start task" button when in single pane layout #38#39
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the issue where the "Create task" button overlaps the "Start task" button in single pane layout. Key changes include:
- Moving the "Create task" button from one conditional block to a new position after the cdk-virtual-scroll-viewport.
- Adding an end-to-end test that verifies the layout via visual regression when the window is resized.
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/app/screen-tasks/screen-tasks.component.html | Repositions the "Create task" button to resolve layout overlapping. |
| e2e/fixtures/tasks.ts | Introduces an e2e visual regression test for single pane layout. |
Files not reviewed (2)
- src/app/screen-task/screen-task.component.scss: Language not supported
- src/app/screen-tasks/screen-tasks.component.scss: Language not supported
Comments suppressed due to low confidence (2)
src/app/screen-tasks/screen-tasks.component.html:57
- The repositioned 'Create task' button is now placed immediately after the virtual scroll viewport. Please ensure that this change does not affect the expected stacking context or interfere with any layout or styling inheritance that might be relied upon elsewhere.
<button
e2e/fixtures/tasks.ts:118
- The new e2e test resizes the window to trigger the single panel layout; verify that these dimensions reliably produce the intended layout across various environments and screen configurations.
await t.resizeWindow(800, 800);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #38