Skip to content

feat: implement modular note editor system with BlockInsertionPanel a…#53

Merged
eedali merged 14 commits into
masterfrom
28-2
Jun 4, 2026
Merged

feat: implement modular note editor system with BlockInsertionPanel a…#53
eedali merged 14 commits into
masterfrom
28-2

Conversation

@eedali

@eedali eedali commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Add Editor.js and support for multiple editor engines

Description

Integrated Editor.js as a native alternative to the Tiptap editor in the Note module. Users can now switch between a block-based editing experience (Editor.js) and the standard WYSIWYG experience (Tiptap) via a new toggle/dropdown in the Settings menu. A safe data transition and parsing mechanism has also been added to prevent data loss or formatting errors when users switch between these two different data structures.

Fixes #28

Type of Change

Please check the options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • UI/UX improvement (visual changes or enhancements)
  • Documentation update

Screenshots / Video

(Yeni eklediğin Settings dropdown menüsünün ve Note modülündeki Editor.js arayüzünün ekran görüntülerini veya videosunu buraya ekleyebilirsin.)

Checklist

Please check all the boxes before submitting your PR:

  • I have tested my code locally and it works flawlessly.
  • I am strictly sure that my changes DO NOT break KoBar's "Ghost Window" (transparent window) and click-through logic.
  • I have added necessary descriptions and comments to my code.
  • My code does not generate any new warnings or errors in the console.

@eedali eedali self-assigned this May 28, 2026
@eedali eedali added the enhancement New feature or request label May 28, 2026
@eedali eedali linked an issue May 28, 2026 that may be closed by this pull request
@eedali eedali requested a review from arindam-sahoo May 28, 2026 22:00
@eedali eedali marked this pull request as ready for review May 28, 2026 22:00

@arindam-sahoo arindam-sahoo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we will try to convert a block to another type of content, it shows two checklist in the list. Reproduce this bug and fix it.

Image

@arindam-sahoo arindam-sahoo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While user will be using the Code Block, they will be facing two issues:

  1. Syntax Highlighting : Code** block content is being rendered as raw HTML/CSS instead of formatted code**

    • In the Python example, content like:

      #98c379;">"color: #c678dd;">def add(a,b):

      is displayed to the user.

    • This suggests syntax-highlighting markup or HTML styles are leaking into the editor output instead of being parsed/rendered correctly.

  2. Inconsistent Syntax Highlighting : Syntax highlighting appears to break after editing a code block. The editor starts displaying raw styling/HTML fragments (e.g. color: #c678dd;">) and newly typed code is no longer highlighted. Code blocks should continue to render syntax highlighting dynamically as content is added or modified. This looks like a rendering/serialization issue in the code block implementation introduced with the EditorJS integration.

Kobar.PR.53.Review.mp4

@eedali eedali marked this pull request as draft May 29, 2026 09:41
@eedali eedali marked this pull request as ready for review May 29, 2026 10:20
@eedali

eedali commented May 29, 2026

Copy link
Copy Markdown
Collaborator Author

@arindam-sahoo Can you check it?

@arindam-sahoo

Copy link
Copy Markdown
Collaborator

When we will try to convert a block to another type of content, it shows two checklist in the list. Reproduce this bug and fix it.

Image

@eedali This is fixed.

@arindam-sahoo

Copy link
Copy Markdown
Collaborator

While user will be using the Code Block, they will be facing two issues:

  1. Syntax Highlighting : Code** block content is being rendered as raw HTML/CSS instead of formatted code**

    • In the Python example, content like:

      #98c379;">"color: #c678dd;">def add(a,b):

      is displayed to the user.

    • This suggests syntax-highlighting markup or HTML styles are leaking into the editor output instead of being parsed/rendered correctly.

  2. Inconsistent Syntax Highlighting : Syntax highlighting appears to break after editing a code block. The editor starts displaying raw styling/HTML fragments (e.g. color: #c678dd;">) and newly typed code is no longer highlighted. Code blocks should continue to render syntax highlighting dynamically as content is added or modified. This looks like a rendering/serialization issue in the code block implementation introduced with the EditorJS integration.

Kobar.PR.53.Review.mp4

@eedali This still needs attention

@arindam-sahoo arindam-sahoo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed another bug, that whichever Heading we create it always remain in only one size, even if we try to change it, it does not.

@eedali

eedali commented May 29, 2026

Copy link
Copy Markdown
Collaborator Author

@arindam-sahoo Can you check again?

@arindam-sahoo

Copy link
Copy Markdown
Collaborator

@arindam-sahoo Can you check again?

Sure

@eedali eedali marked this pull request as draft June 3, 2026 11:37
@arindam-sahoo

Copy link
Copy Markdown
Collaborator

While user will be using the Code Block, they will be facing two issues:

  1. Syntax Highlighting : Code** block content is being rendered as raw HTML/CSS instead of formatted code**

    • In the Python example, content like:

      #98c379;">"color: #c678dd;">def add(a,b):

      is displayed to the user.

    • This suggests syntax-highlighting markup or HTML styles are leaking into the editor output instead of being parsed/rendered correctly.

  2. Inconsistent Syntax Highlighting : Syntax highlighting appears to break after editing a code block. The editor starts displaying raw styling/HTML fragments (e.g. color: #c678dd;">) and newly typed code is no longer highlighted. Code blocks should continue to render syntax highlighting dynamically as content is added or modified. This looks like a rendering/serialization issue in the code block implementation introduced with the EditorJS integration.

Kobar.PR.53.Review.mp4

Fixed. Works as expected.

@arindam-sahoo

Copy link
Copy Markdown
Collaborator

Noticed another bug, that whichever Heading we create it always remain in only one size, even if we try to change it, it does not.

Works Now. WE can go ahead and merge this PR.

@arindam-sahoo arindam-sahoo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the bugs found in the Integration Testing are now working as expected.

@eedali eedali marked this pull request as ready for review June 4, 2026 04:28
@eedali eedali merged commit b5f566d into master Jun 4, 2026
3 checks passed
@eedali eedali deleted the 28-2 branch June 24, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Alternative Editor.js option for the Note module

2 participants