Fix openapi2kong header generation behaviour #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a `TreatAllHeadersAsRequired` option to keep the old behaviour if needed. I do not intend to add a flag to deck yet unless people ask for this functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two header related fixes. Both in the same PR to avoid conflicts
Only generate header routes when required: true
There is a
TreatAllHeadersAsRequiredoption to keep the old behaviour if needed. I do not intend to add a flag to deck yet unless people ask for this functionalityResolves #1838
Create unique plugin IDs when using header routes
Use
operationName+json.Marshal(headers)as part of the ID generation keyResolves #1856