Skip to content

ci: add Release Please flow#38

Open
tkkhq wants to merge 2 commits into
mainfrom
chore/release-please
Open

ci: add Release Please flow#38
tkkhq wants to merge 2 commits into
mainfrom
chore/release-please

Conversation

@tkkhq

@tkkhq tkkhq commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add Release Please config and workflow for stable release PRs.
  • Make publish-cli tag-only for stable releases and reject package.json/tag drift.
  • Document the Release Please release process and required token.

Verification

  • git diff --check
  • parsed Release Please JSON config
  • bash -n scripts/ci/resolve-cli-build-env.sh scripts/install-volcano.sh
  • npm pack --dry-run --ignore-scripts
  • make build FIRST_PARTY_DEVICE_CLIENT_ID=volcano-cli VERSION=v0.0.4
  • ./volcano --version

Copilot AI review requested due to automatic review settings July 7, 2026 22:48
@tkkhq tkkhq requested a review from a team as a code owner July 7, 2026 22:48
Comment thread .github/workflows/release-please.yml Fixed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a Release Please–based stable release flow. It adds Release Please configuration and a workflow that opens/updates release PRs on main, and refactors publish-cli.yml so it triggers only on SemVer tags (removing the previous main-branch/nightly path). Version integrity is now enforced by requiring the tag to match package.json. Documentation is updated to describe the new process and the required RELEASE_PLEASE_TOKEN.

Changes:

  • Add release-please-config.json and .release-please-manifest.json (seeded at 0.0.4, matching package.json) plus a release-please.yml workflow using a PAT so tags trigger follow-on workflows.
  • Make publish-cli.yml tag-only: drop the main trigger and nightly build/alias logic, and reject tag ↔ package.json version drift.
  • Update CONTRIBUTING.md to document the Release Please process and required token/variable.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
release-please-config.json Defines the root node package, tag format, and changelog path for Release Please.
.release-please-manifest.json Seeds the tracked version at 0.0.4.
.github/workflows/release-please.yml Adds the workflow that creates/updates release PRs and tags via a PAT.
.github/workflows/publish-cli.yml Switches to tag-only publishing, adds version-match validation, removes nightly logic and now-unused append_historical_assets.
CONTRIBUTING.md Documents the new Release Please release process and required secret/variable.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CONTRIBUTING.md Outdated
Comment thread .github/workflows/publish-cli.yml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants