ci(workflows): hygiene pass -- concurrency + SHA pin#79
Conversation
Sweep 7 .github/workflows/*.yml: - Add 'concurrency: cancel-in-progress: true' to ci.yml - Pin actions/checkout, trufflehog/actions/setup to immutable SHAs in workflows that reference them - Add 'permissions: contents: read' blocks where missing The ahead docs commit 45d32be (user-story traceability map) is preserved at HEAD; this is a separate, additive hygiene pass on the workflow files. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
📝 WalkthroughWalkthroughThis pull request standardizes GitHub Actions workflow concurrency controls across six workflows to prevent duplicate concurrent runs, applies selective permission scoping and action pinning updates for security and reliability, and introduces a new user-story-to-functional-requirement traceability document mapping seven FRs to source, test, and manifest artifacts with coverage analysis and completion roadmap. ChangesGitHub Actions Workflow Concurrency and Security Updates
Functional Requirement Traceability Documentation
🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
codeant-ai
Bot
added
the
size:M
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new traceability map in docs/traceability/user-story-map.md to track user stories, functional requirements, source files, tests, and journey manifests. The review feedback highlights two main points: first, there is a discrepancy between the PR's stated purpose (updating GitHub workflows) and the actual file changes, which only include the documentation file; second, there is an inconsistency in the document's introductory note regarding the test coverage of FR-006 and FR-007, which actually have partial tests listed in the table.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| @@ -0,0 +1,52 @@ | |||
| # User Story -> Journey -> FR Traceability Map | |||
There was a problem hiding this comment.
The pull request title and description indicate that this PR performs a sweep of .github/workflows/*.yml files to add concurrency configurations, pin actions to immutable SHAs, and add permissions. However, the only file modified in this pull request is docs/traceability/user-story-map.md. The workflow files themselves are not present in the changes.
| - **Authoritative FR doc:** [`FUNCTIONAL_REQUIREMENTS.md`](../../FUNCTIONAL_REQUIREMENTS.md) | ||
| - **Journey standard:** [`docs/operations/journey-traceability.md`](../operations/journey-traceability.md) | ||
| - **Status date:** 2026-06-05 | ||
| - **Note:** All seven FRs are stubs (`Status: Stub`, `Test Status: Not yet written`). Source / test / journey columns are populated where the existing code/test layout already maps to the intent, and `[ ]` boxes mark which rows still need a journey manifest, code, test, and gate wired up. The FR-005 / FR-006 / FR-007 rows are the lowest-coverage rows because they have no test or journey artifact yet. |
There was a problem hiding this comment.
The note states that FR-005, FR-006, and FR-007 have "no test or journey artifact yet." However, the traceability table and the summary below show that FR-006 and FR-007 do have partial/tangential test files associated with them (test_authentication.py and test_api_token.py respectively).\n\nTo maintain accuracy and consistency within the document, consider updating this note to reflect that they have limited/partial test coverage rather than no tests at all.
| - **Note:** All seven FRs are stubs (`Status: Stub`, `Test Status: Not yet written`). Source / test / journey columns are populated where the existing code/test layout already maps to the intent, and `[ ]` boxes mark which rows still need a journey manifest, code, test, and gate wired up. The FR-005 / FR-006 / FR-007 rows are the lowest-coverage rows because they have no test or journey artifact yet. | |
| - **Note:** All seven FRs are stubs (Status: Stub, Test Status: Not yet written). Source / test / journey columns are populated where the existing code/test layout already maps to the intent, and [ ] boxes mark which rows still need a journey manifest, code, test, and gate wired up. The FR-005 / FR-006 / FR-007 rows are the lowest-coverage rows because they have limited or no test coverage and no journey artifacts yet. |
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
| @@ -0,0 +1,52 @@ | |||
| # User Story -> Journey -> FR Traceability Map | |||
There was a problem hiding this comment.
Suggestion: Move this new documentation file into one of the allowed documentation subdirectories (for example docs/reference/ or docs/reports/) so it complies with the required docs hierarchy. [custom_rule]
Severity Level: Minor
Why it matters? 🤔
The repository guidance in AGENTS.md says docs should be kept under docs/guides/, docs/reports/, docs/research/, docs/reference/, or docs/checklists/. This file was added under docs/traceability/, which is not one of the allowed documentation subdirectories, so the suggestion identifies a real rule violation.
Fix in Cursor | Fix in VSCode Claude
(Use Cmd/Ctrl + Click for best experience)
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** docs/traceability/user-story-map.md
**Line:** 1:1
**Comment:**
*Custom Rule: Move this new documentation file into one of the allowed documentation subdirectories (for example `docs/reference/` or `docs/reports/`) so it complies with the required docs hierarchy.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Trufflehog token not interpolated
- Removed the leading backslash from GH_TOKEN so GitHub Actions correctly evaluates ${{ github.token }} instead of passing a literal string.
Or push these changes by commenting:
@cursor push e14e4b7eab
Preview (e14e4b7eab)
diff --git a/.github/workflows/trufflehog.yml b/.github/workflows/trufflehog.yml
--- a/.github/workflows/trufflehog.yml
+++ b/.github/workflows/trufflehog.yml
@@ -21,4 +21,4 @@
- uses: trufflehog/actions/setup@3fc0c2a225a9d249aea9b97a1c40c40a5ff7e0c0
- run: trufflehog github --only-verified --no-update
env:
- GH_TOKEN: \${{ github.token }}
+ GH_TOKEN: ${{ github.token }}You can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit 77d60b2. Configure here.
| - run: trufflehog github --only-verified --no-update | ||
| env: | ||
| GH_TOKEN: \${{ secrets.GITHUB_TOKEN }} | ||
| GH_TOKEN: \${{ github.token }} |
There was a problem hiding this comment.
🔴 Architect Review — CRITICAL
The GH_TOKEN environment variable is set to the escaped literal \${{ github.token }}, so the expression is never evaluated and Trufflehog receives a non-functional token string instead of an actual authentication token.
Suggestion: Remove the escaping so the value is GH_TOKEN: ${{ github.token }}, then verify the Trufflehog GitHub scan step succeeds for both push and pull_request events using the evaluated token.
Fix in Cursor | Fix in VSCode Claude
(Use Cmd/Ctrl + Click for best experience)
Prompt for AI Agent 🤖
This is an **Architect / Logical Review** comment left during a code review. These reviews are first-class, important findings — not optional suggestions. Do NOT dismiss this as a 'big architectural change' just because the title says architect review; most of these can be resolved with a small, localized fix once the intent is understood.
**Path:** .github/workflows/trufflehog.yml
**Line:** 22:24
**Comment:**
*CRITICAL: The GH_TOKEN environment variable is set to the escaped literal `\${{ github.token }}`, so the expression is never evaluated and Trufflehog receives a non-functional token string instead of an actual authentication token.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
If a suggested approach is provided above, use it as the authoritative instruction. If no explicit code suggestion is given, you MUST still draft and apply your own minimal, localized fix — do not punt back with 'no suggestion provided, review manually'. Keep the change as small as possible: add a guard clause, gate on a loading state, reorder an await, wrap in a conditional, etc. Do not refactor surrounding code or expand scope beyond the finding.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
|
CodeAnt AI finished reviewing your PR. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/alert-sync-issues.yml:
- Around line 2-3: The caller workflow's minimal permissions (permissions:
contents: read) prevent the reusable workflow from performing actions that
require broader scopes; update the permissions block in
.github/workflows/alert-sync-issues.yml to include at least issues: write,
security-events: read and actions: read (keeping contents: read) so the reusable
workflow can create/update/comment on issues and read security events and
workflow runs; locate the top-level permissions stanza and expand it accordingly
so the called workflow at commit 438e2e7 can run without being capped by the
caller.
In @.github/workflows/scorecard.yml:
- Around line 8-16: The workflow file `.github/workflows/scorecard.yml` contains
duplicate top-level `permissions` entries - one with `contents: read` and
another with `read-all`. YAML will override the first entry with the second,
which undermines the least-privilege principle and creates ambiguity. Remove one
of the duplicate `permissions` entries to keep only a single top-level
permissions declaration. Determine which permission level is appropriate for
your workflow requirements and delete the redundant entry to avoid confusion and
ensure consistent permission handling.
In @.github/workflows/trufflehog.yml:
- Line 24: Remove the escaping so the GH_TOKEN environment var is interpolated
(change GH_TOKEN: \${{ github.token }} to GH_TOKEN: ${{ github.token }}), and
update the checkout step to set persist-credentials: false so checkout
credentials aren't left available to subsequent steps; modify the workflow's
checkout action configuration (the step that uses actions/checkout) to include
persist-credentials: false and ensure GH_TOKEN uses the unescaped ${{
github.token }} expression.
- Around line 18-20: The checkout step currently uses actions/checkout@v4
without disabling token persistence; update the checkout action configuration
(the step using "actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10") to
set with: persist-credentials: false so the GITHUB_TOKEN/SSH credentials are not
written to the repo git config and cannot be used by subsequent steps.
In `@docs/traceability/user-story-map.md`:
- Around line 1-8: The traceability map document "User Story -> Journey -> FR
Traceability Map" (user-story-map.md) is placed under docs/traceability which
violates the docs layout policy; move the file to the appropriate top-level docs
folder (preferably docs/reference/user-story-map.md if it is a reference
artifact, or docs/reports/traceability-map.md if it is a status/coverage
report), update any relative links inside the document (e.g., the
FUNCTIONAL_REQUIREMENTS.md and journey-traceability.md links) and update any
references to the old path in README/TOC or other docs so the new location
follows the docs/guides|reports|research|reference|checklists structure.
- Around line 19-27: The traceability table references several missing manifest
and source files (see FR-001..FR-004 entries); update the repo and the table so
the referenced files exist and the table is accurate: add or commit the missing
journey manifest files docs/journeys/manifests/planify-workspace-create.json,
planify-cycle-run.json, multistack-bootstrap.json, planify-dep-graph.json and
ensure the source dependency file rust/Planify/apps/api/plane/requirements.txt
is added or the FR-004 row updated to point to the correct existing file; then
update the user-story-map.md rows for FR-001..FR-004 to reference the correct
filenames (or remove the manifest/source references) so entries for Planify
workspace (FR-001), cycle run (FR-002), multistack bootstrap (FR-003) and
dependency graph (FR-004) accurately reflect committed files.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: e751e9f4-ddf5-49e8-8352-9e4ef15f3158
📒 Files selected for processing (8)
.github/workflows/alert-sync-issues.yml.github/workflows/ci.yml.github/workflows/doc-links.yml.github/workflows/fr-coverage.yml.github/workflows/quality-gate.yml.github/workflows/scorecard.yml.github/workflows/trufflehog.ymldocs/traceability/user-story-map.md
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Cursor Bugbot
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: Analyze (javascript-typescript)
🧰 Additional context used
📓 Path-based instructions (4)
docs/**
📄 CodeRabbit inference engine (CLAUDE.md)
Run documentation validation using
vale docs/to check documentation quality
Files:
docs/traceability/user-story-map.md
**/*.{js,ts,tsx,jsx,py,rs,go,java,kt,scala,cs,rb,php,c,cpp,h,hpp,m,swift,json,yaml,yml,toml,xml,html,css,scss,less,md}
📄 CodeRabbit inference engine (AGENTS.md)
All code MUST pass linting and formatting checks before commit; run linters and formatters locally, fix errors without suppressing warnings, and commit all formatting changes before feature changes
Files:
docs/traceability/user-story-map.md
**/*.md
📄 CodeRabbit inference engine (AGENTS.md)
Use Vale for Markdown validation where available
Files:
docs/traceability/user-story-map.md
docs/**/*.md
📄 CodeRabbit inference engine (AGENTS.md)
Keep documentation organized per global structure in
docs/guides/,docs/reports/,docs/research/,docs/reference/,docs/checklists/
Files:
docs/traceability/user-story-map.md
🪛 LanguageTool
docs/traceability/user-story-map.md
[uncategorized] ~21-~21: The official name of this software platform is spelled with a capital “H”.
Context: ...nify-workspace-create.json(planned) |.github/workflows/fr-coverage.yml` | [ ] | [x] ...
(GITHUB)
[uncategorized] ~22-~22: The official name of this software platform is spelled with a capital “H”.
Context: ...sts/planify-cycle-run.json(planned) |.github/workflows/quality-gate.yml` | [ ] | [x]...
(GITHUB)
[uncategorized] ~23-~23: The official name of this software platform is spelled with a capital “H”.
Context: .../multistack-bootstrap.json(planned) |.github/workflows/ci.yml` | [ ] | [x] | [x] | [...
(GITHUB)
[uncategorized] ~24-~24: The official name of this software platform is spelled with a capital “H”.
Context: ...sts/planify-dep-graph.json(planned) |.github/workflows/ci.yml` | [ ] | [x] | [x] | [...
(GITHUB)
[uncategorized] ~52-~52: The official name of this software platform is spelled with a capital “H”.
Context: ...6/007 are the biggest gaps). - [ ] Wire .github/workflows/fr-coverage.yml to a real FR...
(GITHUB)
🪛 zizmor (1.25.2)
.github/workflows/trufflehog.yml
[warning] 18-20: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false
(artipacked)
[info] 15-15: workflow or action definition without a name (anonymous-definition): this job
(anonymous-definition)
🔇 Additional comments (8)
docs/traceability/user-story-map.md (4)
9-16: LGTM!
29-40: LGTM!
41-46: LGTM!
1-52: Install Vale and runvale docs/for Markdown validation (docs/traceability/user-story-map.md)Vale isn’t available in the current environment (
valecommand not found), so the documentation validation step couldn’t run. Install Vale and executevale docs/(or at minimumvale docs/traceability/user-story-map.md) to satisfy the Markdown validation guidelines..github/workflows/ci.yml (1)
16-18: LGTM!.github/workflows/doc-links.yml (1)
6-8: LGTM!.github/workflows/fr-coverage.yml (1)
6-8: LGTM!.github/workflows/quality-gate.yml (1)
6-8: LGTM!
| | # | User story | FR id | Source file(s) | Test file(s) | Journey page (planned/produced) | Gate | Manifest | Code | Test | Gate wired | | ||
| |---|------------|-------|----------------|--------------|---------------------------------|------|----------|------|------|------------| | ||
| | 1 | As a project lead, I can create and manage a Planify project workspace end-to-end | FR-001 Project workflow management | `rust/Planify/apps/api/plane/app/views/workspace/base.py`, `rust/Planify/apps/api/plane/app/views/project/base.py`, `rust/Planify/apps/web/app/routes/core.ts` | `rust/Planify/apps/api/plane/tests/contract/app/test_workspace_app.py`, `rust/Planify/apps/api/plane/tests/contract/app/test_project_app.py`, `tests/smoke_test.go` (FR-001 trace) | `docs/journeys/manifests/planify-workspace-create.json` (planned) | `.github/workflows/fr-coverage.yml` | [ ] | [x] | [x] | [ ] | | ||
| | 2 | As a team member, I can schedule and execute cycles and tasks inside a project | FR-002 Task scheduling and execution | `rust/Planify/apps/api/plane/app/views/cycle/`, `rust/Planify/apps/api/plane/bgtasks/issue_automation_task.py`, `rust/Planify/apps/api/plane/bgtasks/email_notification_task.py` | `rust/Planify/apps/api/plane/tests/contract/api/test_cycles.py` | `docs/journeys/manifests/planify-cycle-run.json` (planned) | `.github/workflows/quality-gate.yml` | [ ] | [x] | [x] | [ ] | | ||
| | 3 | As a multi-stack maintainer, I can run Planify (TS/Bun) and KaskMan (Go/Node) side by side | FR-003 Multi-language project support | `rust/Planify/` (TS monorepo, Turbo + pnpm), `go/KaskMan/` (Node CLI + Go-style services) | `rust/Planify/packages/codemods/tests/remove-directives.spec.ts`, `rust/Planify/packages/codemods/tests/function-declaration.spec.ts`, `go/KaskMan/src/rnd-module/RnDModule.test.js` | `docs/journeys/manifests/multistack-bootstrap.json` (planned) | `.github/workflows/ci.yml` | [ ] | [x] | [x] | [x] | | ||
| | 4 | As a build engineer, I can resolve and track dependencies across Planify packages | FR-004 Dependency resolution and tracking | `rust/Planify/pnpm-workspace.yaml`, `rust/Planify/turbo.json`, `rust/Planify/package.json` (catalog deps), `rust/Planify/apps/api/plane/requirements.txt` | `rust/Planify/apps/live/tests/services/pdf-export/effect-utils.test.ts`, `rust/Planify/apps/live/tests/lib/pdf/pdf-rendering.test.ts` | `docs/journeys/manifests/planify-dep-graph.json` (planned) | `.github/workflows/ci.yml` | [ ] | [x] | [x] | [x] | | ||
| | 5 | As a release engineer, I can generate and publish build artifacts | FR-005 Artifact generation and publishing | `rust/Planify/apps/api/Dockerfile.api`, `rust/Planify/apps/web/Dockerfile.web`, `rust/Planify/apps/space/Dockerfile.space`, `rust/Planify/deployments/` | none | none | none | [ ] | [x] | [ ] | [ ] | | ||
| | 6 | As an operator, I can manage configuration across environments (env, secrets, Doppler) | FR-006 Configuration management | `rust/Planify/.env.example`, `rust/Planify/doppler.yaml`, `rust/Planify/apps/api/plane/settings/`, `go/KaskMan/.env.example`, `go/KaskMan/dashboard-memory.json` | `rust/Planify/apps/api/plane/tests/contract/app/test_authentication.py` (instance setup touches settings) | none | none | [ ] | [x] | [x] | [ ] | | ||
| | 7 | As an integrator, I can plug into external services via webhooks, exporters, and license checks | FR-007 Integration with external services | `rust/Planify/apps/api/plane/app/views/webhook/`, `rust/Planify/apps/api/plane/bgtasks/export_task.py`, `rust/Planify/apps/api/plane/license/`, `go/KaskMan/src/interfaces/api/server.js` | `rust/Planify/apps/api/plane/tests/contract/app/test_api_token.py` | none | none | [ ] | [x] | [x] | [ ] | |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify file paths referenced in the traceability table exist
echo "=== Checking source files ==="
fd -t f "base.py" rust/Planify/apps/api/plane/app/views/workspace/
fd -t f "base.py" rust/Planify/apps/api/plane/app/views/project/
fd -t f "core.ts" rust/Planify/apps/web/app/routes/
fd -t f "issue_automation_task.py" rust/Planify/apps/api/plane/bgtasks/
fd -t f "email_notification_task.py" rust/Planify/apps/api/plane/bgtasks/
fd -t f "pnpm-workspace.yaml" rust/Planify/
fd -t f "turbo.json" rust/Planify/
fd -t f "Dockerfile.api" rust/Planify/apps/api/
fd -t f ".env.example" rust/Planify/
fd -t f "doppler.yaml" rust/Planify/
fd -t f ".env.example" go/KaskMan/
echo "=== Checking test files ==="
fd -t f "test_workspace_app.py" rust/Planify/apps/api/plane/tests/contract/app/
fd -t f "test_project_app.py" rust/Planify/apps/api/plane/tests/contract/app/
fd -t f "smoke_test.go" tests/
fd -t f "test_cycles.py" rust/Planify/apps/api/plane/tests/contract/api/
fd -t f "remove-directives.spec.ts" rust/Planify/packages/codemods/tests/
fd -t f "test_authentication.py" rust/Planify/apps/api/plane/tests/contract/app/
echo "=== Checking workflow files ==="
fd -t f "fr-coverage.yml" .github/workflows/
fd -t f "quality-gate.yml" .github/workflows/
fd -t f "ci.yml" .github/workflows/
echo "=== Checking referenced docs ==="
fd -t f "FUNCTIONAL_REQUIREMENTS.md"
fd -t f "journey-traceability.md" docs/operations/
echo "=== Checking planned journey manifest directory ==="
ls -la docs/journeys/manifests/ 2>/dev/null || echo "Directory docs/journeys/manifests/ does not exist yet"Repository: KooshaPari/PhenoProject
Length of output: 1313
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Verify all referenced paths from docs/traceability/user-story-map.md
missing=0
check_file() {
local p="$1"
if [ -e "$p" ]; then
echo "OK: $p"
else
echo "MISSING: $p"
missing=1
fi
}
check_dir() {
local p="$1"
if [ -d "$p" ]; then
echo "OK(dir): $p"
else
echo "MISSING(dir): $p"
missing=1
fi
}
echo "=== Verifying exact paths from traceability table ==="
# FR-001
check_file "rust/Planify/apps/api/plane/app/views/workspace/base.py"
check_file "rust/Planify/apps/api/plane/app/views/project/base.py"
check_file "rust/Planify/apps/web/app/routes/core.ts"
check_file "rust/Planify/apps/api/plane/tests/contract/app/test_workspace_app.py"
check_file "rust/Planify/apps/api/plane/tests/contract/app/test_project_app.py"
check_file "tests/smoke_test.go"
check_file "docs/journeys/manifests/planify-workspace-create.json"
check_file ".github/workflows/fr-coverage.yml"
# FR-002
check_dir "rust/Planify/apps/api/plane/app/views/cycle"
check_file "rust/Planify/apps/api/plane/bgtasks/issue_automation_task.py"
check_file "rust/Planify/apps/api/plane/bgtasks/email_notification_task.py"
check_file "rust/Planify/apps/api/plane/tests/contract/api/test_cycles.py"
check_file "docs/journeys/manifests/planify-cycle-run.json"
check_file ".github/workflows/quality-gate.yml"
# FR-003
check_dir "rust/Planify"
check_dir "go/KaskMan"
check_file "rust/Planify/packages/codemods/tests/remove-directives.spec.ts"
check_file "rust/Planify/packages/codemods/tests/function-declaration.spec.ts"
check_file "go/KaskMan/src/rnd-module/RnDModule.test.js"
check_file "docs/journeys/manifests/multistack-bootstrap.json"
check_file ".github/workflows/ci.yml"
# FR-004
check_file "rust/Planify/pnpm-workspace.yaml"
check_file "rust/Planify/turbo.json"
check_file "rust/Planify/package.json"
check_file "rust/Planify/apps/api/plane/requirements.txt"
check_file "rust/Planify/apps/live/tests/services/pdf-export/effect-utils.test.ts"
check_file "rust/Planify/apps/live/tests/lib/pdf/pdf-rendering.test.ts"
check_file "docs/journeys/manifests/planify-dep-graph.json"
check_file ".github/workflows/ci.yml"
# FR-005
check_file "rust/Planify/apps/api/Dockerfile.api"
check_file "rust/Planify/apps/web/Dockerfile.web"
check_file "rust/Planify/apps/space/Dockerfile.space"
check_dir "rust/Planify/deployments/"
# none for test/journey/workflows other than gate wiring in table (no path)
# FR-006
check_file "rust/Planify/.env.example"
check_file "rust/Planify/doppler.yaml"
check_dir "rust/Planify/apps/api/plane/settings/"
check_file "go/KaskMan/.env.example"
check_file "go/KaskMan/dashboard-memory.json"
check_file "rust/Planify/apps/api/plane/tests/contract/app/test_authentication.py"
# none for journey manifest / workflows in table (paths are "none")
# FR-007
check_dir "rust/Planify/apps/api/plane/app/views/webhook"
check_file "rust/Planify/apps/api/plane/bgtasks/export_task.py"
check_dir "rust/Planify/apps/api/plane/license"
check_file "go/KaskMan/src/interfaces/api/server.js"
check_file "rust/Planify/apps/api/plane/tests/contract/app/test_api_token.py"
echo "=== Verifying docs/journeys/manifests/ contents ==="
ls -la docs/journeys/manifests/ || true
if [ "${missing:-0}" -ne 0 ]; then
echo "RESULT: Some referenced paths are missing."
exit 1
fi
echo "RESULT: All referenced paths exist."Repository: KooshaPari/PhenoProject
Length of output: 2520
Fix missing referenced files in traceability table (docs/traceability/user-story-map.md:19-27)
- Missing journey manifests:
docs/journeys/manifests/planify-workspace-create.json(FR-001)docs/journeys/manifests/planify-cycle-run.json(FR-002)docs/journeys/manifests/multistack-bootstrap.json(FR-003)docs/journeys/manifests/planify-dep-graph.json(FR-004)
- Missing source dependency file:
rust/Planify/apps/api/plane/requirements.txt(FR-004)
🧰 Tools
🪛 LanguageTool
[uncategorized] ~21-~21: The official name of this software platform is spelled with a capital “H”.
Context: ...nify-workspace-create.json(planned) |.github/workflows/fr-coverage.yml` | [ ] | [x] ...
(GITHUB)
[uncategorized] ~22-~22: The official name of this software platform is spelled with a capital “H”.
Context: ...sts/planify-cycle-run.json(planned) |.github/workflows/quality-gate.yml` | [ ] | [x]...
(GITHUB)
[uncategorized] ~23-~23: The official name of this software platform is spelled with a capital “H”.
Context: .../multistack-bootstrap.json(planned) |.github/workflows/ci.yml` | [ ] | [x] | [x] | [...
(GITHUB)
[uncategorized] ~24-~24: The official name of this software platform is spelled with a capital “H”.
Context: ...sts/planify-dep-graph.json(planned) |.github/workflows/ci.yml` | [ ] | [x] | [x] | [...
(GITHUB)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/traceability/user-story-map.md` around lines 19 - 27, The traceability
table references several missing manifest and source files (see FR-001..FR-004
entries); update the repo and the table so the referenced files exist and the
table is accurate: add or commit the missing journey manifest files
docs/journeys/manifests/planify-workspace-create.json, planify-cycle-run.json,
multistack-bootstrap.json, planify-dep-graph.json and ensure the source
dependency file rust/Planify/apps/api/plane/requirements.txt is added or the
FR-004 row updated to point to the correct existing file; then update the
user-story-map.md rows for FR-001..FR-004 to reference the correct filenames (or
remove the manifest/source references) so entries for Planify workspace
(FR-001), cycle run (FR-002), multistack bootstrap (FR-003) and dependency graph
(FR-004) accurately reflect committed files.
- trufflehog.yml: interpolate \${{ github.token }} (was backslash-escaped,
CRITICAL per coderabbitai review)
- trufflehog.yml: add persist-credentials: false to checkout step
- scorecard.yml: drop duplicate top-level `permissions: read-all` block
(YAML override was undermining least-privilege)
- scorecard.yml: hoist `security-events: write`, `id-token: write`,
`actions: read` to workflow-level so the reusable workflow isn't capped
- alert-sync-issues.yml: add `issues: write`, `security-events: read`,
`actions: read` to caller permissions so the phenoShared reusable
workflow at 438e2e7 can perform alert-sync actions
- docs(reports): relocate traceability/user-story-map.md to
docs/reports/ per AGENTS.md docs hierarchy
- docs(reports): fix prose about FR-005/006/007 — FR-006 has partial test
(auth touches settings), FR-007 has partial test (api token), only
FR-005 truly has no test artifact yet
Refs: #79
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
CodeAnt AI is running Incremental review Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
codeant-ai
Bot
added
size:M
|
CodeAnt AI Incremental review completed. |
|
KooshaPari
dismissed
coderabbitai[bot]’s stale review
Stale review - issues addressed
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/scorecard.yml:
- Around line 10-12: The workflow-level permissions block is granting elevated
scopes (security-events, id-token, actions) globally; remove or narrow the
top-level permissions block so those elevated scopes are only defined under
jobs.analysis.permissions (leave jobs.analysis.permissions as-is) to ensure
least-privileged defaults for other jobs—specifically delete the top-level
"permissions" entries (security-events: write, id-token: write, actions: read)
and rely on the existing jobs.analysis.permissions stanza to provide those
scopes only to the analysis job.
In `@docs/reports/user-story-map.md`:
- Line 5: Fix the broken "Journey standard" markdown link in
docs/reports/user-story-map.md by changing the link target from
../../operations/journey-traceability.md to
../operations/journey-traceability.md so it correctly points one directory up;
update the markdown link text `[../../operations/journey-traceability.md]`
accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 58fd22c6-b878-4627-9156-f6453c35e3ef
📒 Files selected for processing (4)
.github/workflows/alert-sync-issues.yml.github/workflows/scorecard.yml.github/workflows/trufflehog.ymldocs/reports/user-story-map.md
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: semgrep-cloud-platform/scan
- GitHub Check: Analyze (javascript-typescript)
🧰 Additional context used
📓 Path-based instructions (4)
docs/**
📄 CodeRabbit inference engine (CLAUDE.md)
Run documentation validation using
vale docs/to check documentation quality
Files:
docs/reports/user-story-map.md
**/*.{js,ts,tsx,jsx,py,rs,go,java,kt,scala,cs,rb,php,c,cpp,h,hpp,m,swift,json,yaml,yml,toml,xml,html,css,scss,less,md}
📄 CodeRabbit inference engine (AGENTS.md)
All code MUST pass linting and formatting checks before commit; run linters and formatters locally, fix errors without suppressing warnings, and commit all formatting changes before feature changes
Files:
docs/reports/user-story-map.md
**/*.md
📄 CodeRabbit inference engine (AGENTS.md)
Use Vale for Markdown validation where available
Files:
docs/reports/user-story-map.md
docs/**/*.md
📄 CodeRabbit inference engine (AGENTS.md)
Keep documentation organized per global structure in
docs/guides/,docs/reports/,docs/research/,docs/reference/,docs/checklists/
Files:
docs/reports/user-story-map.md
🪛 zizmor (1.25.2)
.github/workflows/scorecard.yml
[warning] 10-10: overly broad permissions (excessive-permissions): security-events: write is overly broad at the workflow level
(excessive-permissions)
[error] 11-11: overly broad permissions (excessive-permissions): id-token: write is overly broad at the workflow level
(excessive-permissions)
[warning] 10-10: permissions without explanatory comments (undocumented-permissions): needs an explanatory comment
(undocumented-permissions)
.github/workflows/alert-sync-issues.yml
[error] 4-4: overly broad permissions (excessive-permissions): issues: write is overly broad at the workflow level
(excessive-permissions)
[warning] 4-4: permissions without explanatory comments (undocumented-permissions): needs an explanatory comment
(undocumented-permissions)
🔇 Additional comments (3)
docs/reports/user-story-map.md (1)
1-53: Please attach doc validation output for this change set.I don’t see evidence in this PR context that Markdown/doc validation was run for
docs/**. Please run and share output forvale docs/(and your configured markdown lint/format checks) to confirm guideline compliance.
As per coding guidelines, “Use Vale for Markdown validation where available” and “Run documentation validation usingvale docs/to check documentation quality.”Source: Coding guidelines
.github/workflows/alert-sync-issues.yml (1)
4-6: LGTM!.github/workflows/trufflehog.yml (1)
21-21: LGTM!Also applies to: 25-25
| security-events: write | ||
| id-token: write | ||
| actions: read |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
FILE=".github/workflows/scorecard.yml"
echo "== Top-level permissions =="
awk 'NR>=1&&NR<=20{printf "%4d %s\n", NR, $0}' "$FILE" | sed -n '/^ *8 /,/^ *13 /p'
echo
echo "== Job-level permissions =="
awk 'NR>=20&&NR<=35{printf "%4d %s\n", NR, $0}' "$FILE" | sed -n '/permissions:/,/^ *30 /p'Repository: KooshaPari/PhenoProject
Length of output: 400
🏁 Script executed:
#!/bin/bash
set -euo pipefail
FILE=".github/workflows/scorecard.yml"
echo "== File (with line numbers, first 200 lines) =="
nl -ba "$FILE" | sed -n '1,200p'
echo
echo "== Occurrences of 'permissions:' =="
rg -n "^[[:space:]]*permissions:" "$FILE" || true
echo
echo "== Occurrences of 'jobs:' =="
rg -n "^[[:space:]]*jobs:" "$FILE" || true
echo
echo "== Job keys under jobs: (approx) =="
awk '
$0 ~ /^[[:space:]]{2}jobs:/ {injobs=1; next}
injobs && $0 ~ /^[[:space:]]{4}[A-Za-z0-9_-]+:/ {print NR ":" $0}
$0 !~ /^[[:space:]]/ {if(injobs) injobs=0}
' "$FILE" || trueRepository: KooshaPari/PhenoProject
Length of output: 176
🏁 Script executed:
#!/bin/bash
set -euo pipefail
FILE=".github/workflows/scorecard.yml"
echo "== File (with line numbers, first 200 lines) =="
cat -n "$FILE" | sed -n '1,200p'
echo
echo "== Occurrences of 'permissions:' =="
rg -n "^[[:space:]]*permissions:" "$FILE" || true
echo
echo "== Occurrences of 'jobs:' =="
rg -n "^[[:space:]]*jobs:" "$FILE" || trueRepository: KooshaPari/PhenoProject
Length of output: 1637
🏁 Script executed:
#!/bin/bash
set -euo pipefail
FILE=".github/workflows/scorecard.yml"
echo "== wc -l =="
wc -l "$FILE"
echo
echo "== tail -n 80 =="
tail -n 80 "$FILE"Repository: KooshaPari/PhenoProject
Length of output: 1200
🏁 Script executed:
#!/bin/bash
set -euo pipefail
FILE=".github/workflows/scorecard.yml"
echo "== wc -l =="
wc -l "$FILE"
echo
echo "== tail -n 80 =="
tail -n 80 "$FILE"Repository: KooshaPari/PhenoProject
Length of output: 1200
Keep elevated token scopes job-scoped only.
Top-level workflow permissions grants security-events: write, id-token: write, and actions: read, even though jobs.analysis.permissions already defines them—removing the workflow-level scopes keeps defaults least-privileged for any future jobs.
Suggested fix
permissions:
contents: read
- security-events: write
- id-token: write
- actions: read🧰 Tools
🪛 zizmor (1.25.2)
[warning] 10-10: overly broad permissions (excessive-permissions): security-events: write is overly broad at the workflow level
(excessive-permissions)
[error] 11-11: overly broad permissions (excessive-permissions): id-token: write is overly broad at the workflow level
(excessive-permissions)
[warning] 10-10: permissions without explanatory comments (undocumented-permissions): needs an explanatory comment
(undocumented-permissions)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/scorecard.yml around lines 10 - 12, The workflow-level
permissions block is granting elevated scopes (security-events, id-token,
actions) globally; remove or narrow the top-level permissions block so those
elevated scopes are only defined under jobs.analysis.permissions (leave
jobs.analysis.permissions as-is) to ensure least-privileged defaults for other
jobs—specifically delete the top-level "permissions" entries (security-events:
write, id-token: write, actions: read) and rely on the existing
jobs.analysis.permissions stanza to provide those scopes only to the analysis
job.
Source: Linters/SAST tools
|
|
||
| - **Repo:** PhenoProject | ||
| - **Authoritative FR doc:** [`FUNCTIONAL_REQUIREMENTS.md`](../../FUNCTIONAL_REQUIREMENTS.md) | ||
| - **Journey standard:** [`../../operations/journey-traceability.md`](../../operations/journey-traceability.md) |
There was a problem hiding this comment.
Fix broken relative link for journey standard.
The link target is off by one directory. From docs/reports/user-story-map.md, it should point to ../operations/journey-traceability.md, not ../../operations/....
Proposed patch
-- **Journey standard:** [`../../operations/journey-traceability.md`](../../operations/journey-traceability.md)
+- **Journey standard:** [`../operations/journey-traceability.md`](../operations/journey-traceability.md)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - **Journey standard:** [`../../operations/journey-traceability.md`](../../operations/journey-traceability.md) | |
| - **Journey standard:** [`../operations/journey-traceability.md`](../operations/journey-traceability.md) |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/reports/user-story-map.md` at line 5, Fix the broken "Journey standard"
markdown link in docs/reports/user-story-map.md by changing the link target from
../../operations/journey-traceability.md to
../operations/journey-traceability.md so it correctly points one directory up;
update the markdown link text `[../../operations/journey-traceability.md]`
accordingly.
1 participant
User description
Sweep 7
.github/workflows/*.yml:in workflows that reference them
The ahead docs commit 45d32be (user-story traceability map) is
preserved at HEAD~1; this is a separate, additive hygiene pass on
the workflow files.
Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com
Note
Low Risk
Changes are CI configuration and documentation only; Trufflehog still scans with read-only repo access and the built-in token.
Overview
GitHub Actions hygiene across seven workflows: each now declares
concurrencywithcancel-in-progress: trueso a new run on the same ref cancels stale jobs (CI, doc-links, FR coverage, quality gate, scorecard, trufflehog, alert-sync).Permissions are tightened or made explicit:
alert-sync-issuesmoves scoped permissions to the workflow top (issues write, security-events/actions read);scorecarddropsread-allfor explicit read/write scopes;trufflehogaddscontents: readat workflow level.Trufflehog pins
actions/checkoutandtrufflehog/actions/setupto immutable SHAs, setspersist-credentials: false, and usesgithub.tokeninstead ofsecrets.GITHUB_TOKEN.Documentation: adds
docs/reports/user-story-map.md, a user-story → FR traceability table with code/test/journey/gate checkboxes and coverage gaps (FR-005–007 called out as lowest).Reviewed by Cursor Bugbot for commit 001a75e. Bugbot is set up for automated code reviews on this repo. Configure here.
CodeAnt-AI Description
Tighten workflow runs and add a user-story traceability map
What Changed
Impact
✅ Fewer stale CI runs✅ Safer security scans✅ Clearer workflow access rules✅ Easier coverage review for functional requirements💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.