fix(sidekick): remove dangling phenotype-errors and unused workspace deps#77
fix(sidekick): remove dangling phenotype-errors and unused workspace deps#77KooshaPari wants to merge 1 commit into
Conversation
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Free Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughSix workspace-level shared dependencies ( ChangesWorkspace Dependency Cleanup
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Note 🎁 Summarized by CodeRabbit FreeThe PR author is not assigned a seat. To perform a comprehensive line-by-line review, please assign a seat to the pull request author through the subscription management page by visiting https://app.coderabbit.ai/login. Comment |
There was a problem hiding this comment.
Code Review
This pull request cleans up the workspace dependencies in Cargo.toml by removing unused dependencies such as tokio, serde_json, tracing, anyhow, clap, and phenotype-errors, leaving only serde and thiserror. The Cargo.lock file has been updated accordingly to reflect these changes. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|



Summary
Remove dangling
phenotype-errorslocal-path workspace dependency and unused workspace deps that break CI once billing is restored.Context
Commit 7d22543 cleaned up
sidekick-messagingby removing its dependency on the archivedphenotype-buscrate and thephenotype-errorscrate. However, the workspaceCargo.tomlstill declaresphenotype-errors = { path = "../pheno/crates/phenotype-errors" }— a dangling local-path dependency that no workspace member references. This path does not exist in CI, so anycargo check,cargo test, orcargo clippyrun will fail.Additionally, all 5 CI runs on main (CodeQL, CI test, cargo-deny, cargo-machete, Scorecard) currently fail with:
This is a GitHub billing issue affecting runner provisioning. Once billing is resolved, jobs will start again — but the dangling
phenotype-errorsdep will cause immediate build failures.Changes
phenotype-errors = { path = "../pheno/crates/phenotype-errors" }from[workspace.dependencies]inCargo.toml— the only crate that used it (sidekick-messaging) was already cleaned uptokio,serde_json,tracing,anyhow,clap) that no workspace member referencesserdeandthiserrorworkspace deps (still used bysidekick-messaging)Cargo.lockreflecting the pruned dependency treeTesting
Links