Skip to content

chore(cliff): upgrade to v2 template (⚠️ **BREAKING** suffix) #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KooshaPari merged 1 commit into from
Jun 13, 2026
Merged

chore(cliff): upgrade to v2 template (⚠️ **BREAKING** suffix) #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cliff.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# Source: https://github.com/KooshaPari/phenotype-tooling/blob/main/templates/cliff.toml
# Phenotype-org standard cliff.toml v2 (2026-06-11)
# Changes from v1: adds ⚠️ **BREAKING** suffix for commits with `!` prefix
Comment on lines +2 to +3

@codeant-ai codeant-ai Bot Jun 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Architect Review — HIGH

The file is marked as "v2" and documents a new ⚠️ BREAKING suffix for !-prefixed commits, but the [changelog].body template still renders {{ commit.message | upper_first }} without any commit.breaking-based suffix, so the advertised breaking-change behavior is not actually implemented.

Suggestion: Update the commit-rendering line in [changelog].body (currently line 25) to append a conditional commit.breaking suffix (e.g. {% if commit.breaking %} ⚠️ **BREAKING**{% endif %}), then verify via git-cliff --dry-run that feat!:/fix!: commits gain the suffix while non-breaking commits remain unchanged, and only then keep the v2 marker/comment.

Fix in Cursor | Fix in VSCode Claude

(Use Cmd/Ctrl + Click for best experience)

Prompt for AI Agent 🤖 
This is an **Architect / Logical Review** comment left during a code review. These reviews are first-class, important findings — not optional suggestions. Do NOT dismiss this as a 'big architectural change' just because the title says architect review; most of these can be resolved with a small, localized fix once the intent is understood.

**Path:** cliff.toml
**Line:** 2:3
**Comment:**
	*HIGH: The file is marked as "v2" and documents a new ⚠️ **BREAKING** suffix for `!`-prefixed commits, but the `[changelog].body` template still renders `{{ commit.message | upper_first }}` without any `commit.breaking`-based suffix, so the advertised breaking-change behavior is not actually implemented.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
If a suggested approach is provided above, use it as the authoritative instruction. If no explicit code suggestion is given, you MUST still draft and apply your own minimal, localized fix — do not punt back with 'no suggestion provided, review manually'. Keep the change as small as possible: add a guard clause, gate on a loading state, reorder an await, wrap in a conditional, etc. Do not refactor surrounding code or expand scope beyond the finding.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix

# git-cliff config (Phenotype-org standard)
# https://git-cliff.org/docs/configuration

Expand Down
Loading