Skip to content

chore(tooling): add coverage task to Taskfile.yml and justfile #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KooshaPari merged 1 commit into from
Jun 14, 2026
Merged

chore(tooling): add coverage task to Taskfile.yml and justfile #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Taskfile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,8 @@ tasks:
ci:
desc: Run full local CI sweep
cmds: [task lint, task test, task audit]

coverage:
desc: Measure code coverage (SSOT: see grade.sh for the canonical command).

@coderabbitai coderabbitai Bot Jun 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail
python -m pip install --quiet pyyaml
python - <<'PY'
import pathlib, sys, yaml
p = pathlib.Path("Taskfile.yml")
try:
    yaml.safe_load(p.read_text(encoding="utf-8"))
    print("Taskfile.yml parses successfully")
except Exception as e:
    print(f"YAML parse error: {e}")
    sys.exit(1)
PY

Repository: KooshaPari/phenoAI

Length of output: 283

Quote the desc value to fix YAML syntax error.

The unquoted colon in SSOT: see grade.sh creates a mapping value where the parser expects a scalar, causing Taskfile.yml to fail parsing. This violates the coding guideline requiring all YAML files to pass linting before commit.

Fix 
-    desc: Measure code coverage (SSOT: see grade.sh for the canonical command).
+    desc: "Measure code coverage (SSOT: see grade.sh for the canonical command)."
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
desc: Measure code coverage (SSOT: see grade.sh for the canonical command).
desc: "Measure code coverage (SSOT: see grade.sh for the canonical command)."
🧰 Tools
🪛 YAMLlint (1.37.1)

[error] 25-25: syntax error: mapping values are not allowed here

(syntax)

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Taskfile.yml` at line 25, The desc field value contains an unquoted colon in
SSOT: see grade.sh which causes YAML parsing to fail because the colon is
interpreted as a key-value mapping separator rather than part of the string.
Quote the entire desc value (the complete string from "Measure code coverage"
through "canonical command)") to treat the colon as part of the scalar string
literal and resolve the YAML syntax error.

Sources: Coding guidelines, Linters/SAST tools

cmds:
- cargo llvm-cov --workspace --fail-under-lines 85
Comment on lines +24 to +27

@codeant-ai codeant-ai Bot Jun 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Add an explicit AgilePlus spec reference (for example, a spec ID in the task description or adjacent comment) so this new coverage task is traceable to approved planned work. [custom_rule]

Severity Level: Minor ⚠️

Why it matters? 🤔

This is newly added task configuration, and it does not include any AgilePlus spec reference or other traceability marker. The repository guidance says new work should be tied to an existing spec before implementation, so the suggestion correctly identifies a real rule violation.

Fix in Cursor | Fix in VSCode Claude

(Use Cmd/Ctrl + Click for best experience)

Prompt for AI Agent 🤖 
This is a comment left during a code review.

**Path:** Taskfile.yml
**Line:** 24:27
**Comment:**
	*Custom Rule: Add an explicit AgilePlus spec reference (for example, a spec ID in the task description or adjacent comment) so this new `coverage` task is traceable to approved planned work.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
👍 | 👎

3 changes: 3 additions & 0 deletions justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,6 @@ grade-html:
@echo "=== Running grade (HTML) ==="
./grade.sh --html

# Measure code coverage (SSOT: see grade.sh for the canonical command)
coverage:
cargo llvm-cov --workspace --fail-under-lines 85
Comment on lines +27 to +29

@codeant-ai codeant-ai Bot Jun 14, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Add an AgilePlus spec identifier/reference to this newly introduced coverage task (for example in the comment above it) so the implementation is explicitly traceable to an approved spec. [custom_rule]

Severity Level: Minor ⚠️

Why it matters? 🤔

This is a newly introduced feature/task in the justfile, and it does not include any AgilePlus spec identifier or reference. The only comment mentions SSOT/grade.sh, which is not a spec reference. That matches the custom rule requiring new work to be tied to an approved spec before implementation.

Fix in Cursor | Fix in VSCode Claude

(Use Cmd/Ctrl + Click for best experience)

Prompt for AI Agent 🤖 
This is a comment left during a code review.

**Path:** justfile
**Line:** 27:29
**Comment:**
	*Custom Rule: Add an AgilePlus spec identifier/reference to this newly introduced coverage task (for example in the comment above it) so the implementation is explicitly traceable to an approved spec.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
👍 | 👎

Loading