chore(phenoUtils): P0 cleanup — standardize justfile, update STATUS.md#54
chore(phenoUtils): P0 cleanup — standardize justfile, update STATUS.md#54KooshaPari wants to merge 7 commits into
Conversation
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Warning Review limit reached
More reviews will be available in 28 minutes and 28 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (13)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the status documentation in STATUS.md, removes the Taskfile.yml build configuration, and adds a new [bans] section to deny.toml. A critical issue was identified in deny.toml where unsupported configuration keys (such as workspace-features and multiple-mains) were added to the [bans] section, which would cause cargo deny check to fail. It is recommended to replace these invalid keys with supported ones like multiple-versions = "deny".
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| [bans] | ||
| workspace-features = "deny" | ||
| multiple-mains = "deny" | ||
| main = "deny" | ||
| unnameable-traits = "deny" | ||
| unnameable-types = "deny" | ||
| unknown-lints = "deny" | ||
|
|
There was a problem hiding this comment.
The cargo-deny tool does not support these keys (such as workspace-features, multiple-mains, etc.) in the [bans] section of deny.toml. Including them will cause cargo deny check to fail with a configuration parsing error.
If you intended to configure Rust compiler/clippy lints, those should be defined in Cargo.toml under [workspace.lints.rust] or [workspace.lints.clippy]. If you want to use cargo-deny to prevent multiple versions of the same crate, you can use multiple-versions = "deny" instead.
| [bans] | |
| workspace-features = "deny" | |
| multiple-mains = "deny" | |
| main = "deny" | |
| unnameable-traits = "deny" | |
| unnameable-types = "deny" | |
| unknown-lints = "deny" | |
| [bans] | |
| multiple-versions = "deny" | |
codeant-ai
Bot
added
the
size:M
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is ON. A cloud agent has been kicked off to fix the reported issues.
Reviewed by Cursor Bugbot for commit 9c06319. Configure here.
| - uses: dtolnay/rust-toolchain@stable | ||
| - uses: Swatinem/rust-cache@v2 | ||
| - run: cargo test --all-features --workspace | ||
| - run: cargo clippy --all-features -- -D warnings 2>/dev/null || cargo check |
There was a problem hiding this comment.
Clippy failures masked by fallback
High Severity
The CI lint step runs cargo clippy with -D warnings, redirects stderr to /dev/null, and on any non-zero exit runs cargo check instead. A failing Clippy run can still leave the job green, so warning-level lint regressions never fail the pipeline.
Reviewed by Cursor Bugbot for commit 9c06319. Configure here.
| main = "deny" | ||
| unnameable-traits = "deny" | ||
| unnameable-types = "deny" | ||
| unknown-lints = "deny" |
There was a problem hiding this comment.
Invalid keys in deny.toml
Medium Severity
The new [bans] entries (workspace-features, multiple-mains, main, unnameable-traits, unnameable-types, unknown-lints) are not valid cargo-deny ban settings. They match Cargo manifest lint names, so cargo deny check is likely to fail when parsing this file.
Reviewed by Cursor Bugbot for commit 9c06319. Configure here.
|
CodeAnt AI finished reviewing your PR. |
1 participant
User description
Summary
justfile; remove redundantTaskfile.ymlSTATUS.mdwith current state (2026-06-08)QA
Note
Low Risk
Changes are CI, docs, and deny policy only; the new deny bans may fail future cargo-deny runs if the workspace violates them, but no runtime application code is touched.
Overview
Build tooling: Removes
Taskfile.ymlso local workflows rely on the existingjustfileonly;STATUS.mdis refreshed (2026-06-08) with repo state, billing note, and recent cleanup (PR #53, stale branches).GitHub Actions: Adds a new
CIworkflow on push/PR (cargo test+ clippy/check with rust-cache). Most other workflows get concurrency (cancel-in-progress),ubuntu-24.04runners, and a few pinned action SHAs (e.g.cargo-denyrust-toolchain, Scorecard).ci.ymlstill usesubuntu-latestand floating@v4/@stabletags unlike the pinned workflows.Policy: Extends
deny.tomlwith a[bans]block (workspace-features, multiple-mains, unnameable types/traits, unknown-lints, etc.) socargo-denywill enforce stricter crate/workspace rules when runs are unblocked.Reviewed by Cursor Bugbot for commit 9c06319. Bugbot is set up for automated code reviews on this repo. Configure here.
CodeAnt-AI Description
Standardize repo workflows and tighten CI checks
What Changed
cargo-denyTaskfile.yml, keepingjustfileas the single local build toolSTATUS.mdwith the current repo state and recent cleanupImpact
✅ Fewer duplicate CI runs✅ More consistent workflow behavior✅ Earlier detection of dependency policy issues💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.