Skip to content

fix(ci): repair coverage workflow job condition expressions#188

Open
KooshaPari wants to merge 1 commit into
mainfrom
fix/ci-green-cur
Open

fix(ci): repair coverage workflow job condition expressions#188
KooshaPari wants to merge 1 commit into
mainfrom
fix/ci-green-cur

Conversation

@KooshaPari

@KooshaPari KooshaPari commented Jun 26, 2026

Copy link
Copy Markdown
Owner

User description

Summary

  • Fixes .github/workflows/coverage.yml failing at workflow validation on main (0 jobs, instant failure).
  • Root cause: job-level if conditions referenced env.SKIP, which is not available in the if context — only vars, github, etc. are valid there.
  • Change: use vars.SKIP || '' directly in each job if guard.

Failing check fixed

.github/workflows/coverage.yml (workflow name: ci) — annotation was:

Unrecognized named-value: 'env'. Located at position 11 within expression: !contains(env.SKIP, 'lint')

Local quality checks run

Check Result
coverage.yml YAML validation pass
cargo fmt --all -- --check pass (exit 0; nightly-only rustfmt option warnings pre-existing on main)
cargo clippy / test / build --release pre-existing main blockerpheno-tracing git tag v0.4.0 does not exist on GitHub; unrelated to this workflow-only diff

Remaining red checks on main (not in scope)

These still fail workflow validation and need separate PRs:

Workflow Error
.github/workflows/ci.yml Invalid reusable workflow ref (phenoShared SHA / top-level path)
.github/workflows/deny.yml Reusable workflow not at .github/workflows/ top level
.github/workflows/security.yml Invalid ${{{{ github.repository }}}} expression on line 66

Test plan

  • Push branch and confirm coverage.yml workflow validates and jobs run
  • Verify lint/test/coverage echo jobs complete on PR checks

CodeAnt-AI Description

Fix coverage workflow validation on CI

What Changed

  • Coverage workflow jobs now read the skip list in a way GitHub Actions accepts, so the workflow validates and can run again
  • Lint, test, and coverage jobs still honor the same skip keywords, but without breaking the workflow on startup

Impact

✅ CI workflow runs without validation errors
✅ Fewer broken coverage checks on main
✅ Reliable lint, test, and coverage job skipping

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Job-level if expressions cannot reference workflow env context; use
repository variables directly so GitHub Actions validates the workflow.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@codeant-ai

codeant-ai Bot commented Jun 26, 2026

Copy link
Copy Markdown

CodeAnt AI is reviewing your PR.

@codeant-ai

codeant-ai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@KooshaPari, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 25 minutes and 1 second. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 7f5db59c-1f89-41dd-8c52-f147e2b5db30

📥 Commits

Reviewing files that changed from the base of the PR and between 71a01c5 and 7b20236.

📒 Files selected for processing (1)
  • .github/workflows/coverage.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ci-green-cur
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/ci-green-cur

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codeant-ai codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Jun 26, 2026
@socket-security

Copy link
Copy Markdown

Dependency limit exceeded — report not shown.

This pull request scan exceeded the 10,000-dependency limit applied to this scan, so the results are incomplete and may be inaccurate. To avoid reporting false positives, Socket has not posted a report.

Upgrade your plan to raise the dependency limit and get complete reports, or view the partial scan in the dashboard.

Socket is always free for open source. If this is a non-commercial open source project, contact us to request a free Team account.

@codeant-ai

codeant-ai Bot commented Jun 26, 2026

Copy link
Copy Markdown

CodeAnt AI finished reviewing your PR.

@sonarqubecloud

Copy link
Copy Markdown

@kilo-code-bot

kilo-code-bot Bot commented Jun 28, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • .github/workflows/coverage.yml - Workflow configuration fix

Reviewed by laguna-m.1-20260312:free · Input: 105.7K · Output: 2.8K · Cached: 143.6K

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant