feat: add search#287
Conversation
only parse from and to dates when searching toggle between date formats when searching refactoring change date formatting for searched events raise exception when search dates not given
|
Thanks! I'll be very busy this week, I'll take a look this weekend :) |
| show_graph: bool, | ||
| ) -> dumper.Dumper: | ||
| try: | ||
| if search_from is None or search_to is None: |
There was a problem hiding this comment.
I'm realizing that if user doesn't provide the --from argument, we could assert that we want to search from the current date by default? What do you think?
There was a problem hiding this comment.
Yeah, that makes sense to me!
| help=_("The date to begin searching for events."), | ||
| ) | ||
| parser.add_argument( | ||
| "--to", type=str, default=None, help=_("The date to end searching for events.") |
There was a problem hiding this comment.
If we make --from optional as proposed, then we should perhaps rename this argument to --until?
nicfb
force-pushed
the
feat/add-search
branch
from
16a9b29 to
16cbbb6
Compare
|
Hello! Sorry, I know it's been quite a while. I just noticed this was still open. Could you remind me what the status of this was? Please let me know if I can help close this out. |
|
Hey @nicfb, sorry for the late answer, currently having some personal issues I have to take care of ^^ I'll check and merge your PR as soon as possible to unblock this :) |
|
No worries at all. I just wanted to make sure it wasn't something on my end that needed to be changed. Please let me know if I can help! I'm hoping to have some more free time this year to contribute if needed. |
2 participants
Checklist:
This PR makes use of the event searching capability added to Kosmorrolib in version 1.1. It will allow users to search for specific events in a given date range.
I don't think this is 100% complete yet, but I wanted to get your feedback on it.