Open
Conversation
* treat the 'groups' config key similar to the 'user' config key
- BREAKING CHANGE: make 'group' a pattern instead of a list
- same "format" as the 'user' and 'collection' keys
- allow for easy expression of "any": .+
- allow giving "{group}" in the 'collection' pattern
* fix the rule matching logic
- if both keys, 'user' and 'groups', are given,
both need to match, and both can be used in the 'collection' pattern
- if only one is given, only the given one needs to match,
and only the given one can be used in the 'collection' pattern
- if none is given, the rule will always fail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is work in progress: undocumented and untested in context - please feel free to comment., but do not merge yet