fix(ui): align filter-bar heights and compact MESH LIVE panel#1182
Open
efiten wants to merge 2 commits into
Open
fix(ui): align filter-bar heights and compact MESH LIVE panel#1182efiten wants to merge 2 commits into
efiten wants to merge 2 commits into
Conversation
.btn and .col-toggle-btn carry min-height:48px from the WCAG touch-target
rule, overriding the explicit height:34px on .filter-bar .btn. This made
buttons like 'Group by Hash', '★ My Nodes', and 'Columns ▾' visibly taller
than the multi-select-trigger buttons ('All Observers', 'All Regions') which
don't carry the .btn class and were already correct at 34px.
Add min-height:34px to .filter-bar .btn, .filter-group .btn, and
.filter-bar .col-toggle-btn. Touch targets unchanged on mobile (≤767px
media query remains authoritative there).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
.live-overlay sets flex-direction:column on all overlay panels, but .live-header did not override it. With the new #liveAreaFilter child visible (populated once areas are configured), the panel stacked 4 rows: title, stats, toggles, area filter — taking ~1/3 of viewport height. Switch .live-header to flex-direction:row with flex-wrap:wrap so title and stats share the first line. Give .live-toggles flex:0 0 100% to force it to a second line. Move #liveAreaFilter inside .live-toggles so the area dropdown is inline with the other controls, eliminating the standalone fourth row. Audio controls get flex:0 0 100% so they still span a full row when shown. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Filter bar heights:
.btnand.col-toggle-btncarriedmin-height:48pxfrom the WCAG touch-target rule, making buttons likeGroup by Hash,★ My Nodes,Columns ▾, and text inputs visibly taller than themulti-select-trigger/region-dropdown-triggercontrols (which don't carry.btnand were already correct at 34px). Fix addsmin-height:34pxoverrides to.filter-bar .btn,.filter-group .btn,.filter-bar .col-toggle-btn, and.filter-bar input, .filter-bar selectso the entire filter bar renders at a uniform 34px on desktop.MESH LIVE panel:
.live-overlaysetsflex-direction:columnon all overlay panels;.live-headerdid not override this. With#liveAreaFilterpopulated (when areas are configured), the panel stacked 4 rows — title, stats, toggles, area filter — consuming ~⅓ of viewport height. Switch.live-headertoflex-direction:row; flex-wrap:wrap, give.live-togglesflex:0 0 100%to force it to its own line, and move#liveAreaFilterinside.live-togglesso the area dropdown is inline with the other controls. Panel shrinks from 4 rows to 2 rows.Test plan
Filters ▾, text inputs,All Observers,All Types,Group by Hash,★ My Nodes,Columns ▾,Hex Pathsall render at uniform ~34px height on desktopArea: All ▾appears inline in the toggles row when areas are configured; panel hides the area control entirely when no areas are configured (existing behavior)🤖 Generated with Claude Code