feat(live): slow-mo playback — sub-1x VCR speeds (closes #771 M1)#922
Open
efiten wants to merge 2 commits intoKpa-clawbot:masterfrom
Open
feat(live): slow-mo playback — sub-1x VCR speeds (closes #771 M1)#922efiten wants to merge 2 commits intoKpa-clawbot:masterfrom
efiten wants to merge 2 commits intoKpa-clawbot:masterfrom
Conversation
…-clawbot#771 M1) Adds 0.25x and 0.5x speeds to the VCR speed cycle [0.25, 0.5, 1, 2, 4, 8]. Speed button shows ¼x / ½x labels. Animation duration scales with speed (drawAnimatedLine step interval, drawMatrixLine DURATION_MS). Speed preference persisted to localStorage and restored on page load. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
page.$() captures an element handle at query time. When the nodes page WebSocket auto-refresh fires between the querySelector and the .click() call, the table is re-rendered and the element is detached, causing "Element is not attached to the DOM". Replace both occurrences with page.click(selector), which re-queries the DOM at click time and retries until the element is stable. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
Expert Review — PR #922Verdict: NEEDS-WORK (rebase required)
MAJOR
MINOR
Positives
Tests
To merge
Good work overall — just needs the rebase. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends VCR speed cycle to
[0.25, 0.5, 1, 2, 4, 8]so users can watch live paths in slow motion.Changes
vcrSpeedCycle(): speed array extended to include¼xand½x; saves preference tolocalStorage('live-vcr-speed')speedLabel(): new helper returning¼x/½xfor sub-1x, used in the speed buttondrawAnimatedLine: step interval scales with speed (33 / VCR.speed)drawMatrixLine:DURATION_MSscales with speed (1100 / VCR.speed)Tests
3 new unit tests; 72 pass, 0 regressions.
Closes #771 (M1 of 3)