Skip to content

Feature/init#1

Merged
krakenhavoc merged 11 commits intomainfrom
feature/init
Mar 12, 2026
Merged

Feature/init#1
krakenhavoc merged 11 commits intomainfrom
feature/init

Conversation

@krakenhavoc
Copy link
Contributor

@krakenhavoc krakenhavoc commented Mar 12, 2026

This pull request implements the core API client logic for the project, replacing all previous stubs with real HTTP requests, and updates the account and authentication command handlers to use these new client methods. It also adds comprehensive tests for the API client, introduces a custom configuration for the linter, and updates CI workflows for improved Go and linter management.

Major implementation of API client and command handlers:

  • Implements a full-featured do method in internal/api/client.go to handle HTTP requests, error mapping, and JSON (de)serialization. All API client methods (CreateDomain, ListDomains, GetProfile, ListAPIKeys, etc.) are now implemented using this method, replacing previous panic("not implemented") stubs.
  • Updates the internal/account/account.go and internal/auth/auth.go command handlers to call the new API client methods, providing real functionality for account and authentication-related commands. [1] [2]

Testing improvements:

  • Adds a comprehensive test suite in internal/api/client_test.go that verifies correct request construction, error handling, and response parsing for the API client.

Linting and CI workflow updates:

  • Adds a .golangci.yml file to customize golangci-lint behavior, including exclusions for certain functions.
  • Updates CI workflows to use newer versions of actions/setup-go and switches to installing and running golangci-lint directly rather than via the GitHub Action. [1] [2] [3]

@krakenhavoc krakenhavoc merged commit 57c4d69 into main Mar 12, 2026
1 check passed
@krakenhavoc krakenhavoc deleted the feature/init branch March 12, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant