Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements the core API client logic for the project, replacing all previous stubs with real HTTP requests, and updates the account and authentication command handlers to use these new client methods. It also adds comprehensive tests for the API client, introduces a custom configuration for the linter, and updates CI workflows for improved Go and linter management.
Major implementation of API client and command handlers:
domethod ininternal/api/client.goto handle HTTP requests, error mapping, and JSON (de)serialization. All API client methods (CreateDomain,ListDomains,GetProfile,ListAPIKeys, etc.) are now implemented using this method, replacing previouspanic("not implemented")stubs.internal/account/account.goandinternal/auth/auth.gocommand handlers to call the new API client methods, providing real functionality for account and authentication-related commands. [1] [2]Testing improvements:
internal/api/client_test.gothat verifies correct request construction, error handling, and response parsing for the API client.Linting and CI workflow updates:
.golangci.ymlfile to customizegolangci-lintbehavior, including exclusions for certain functions.actions/setup-goand switches to installing and runninggolangci-lintdirectly rather than via the GitHub Action. [1] [2] [3]