Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving error handling and code quality throughout the codebase, especially in test files and server shutdown logic. It also introduces a pre-commit configuration to enforce code linting and testing standards. The main themes are enhanced error checking, better resource cleanup, and improved maintainability.
Error handling improvements:
os.WriteFilein multiple test cases ininternal/config/config_test.goandinternal/state/state_test.go, causing tests to fail if file writing fails. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]internal/health/health.go,internal/health/health_test.go,internal/reporter/reporter_test.go,internal/scanner/scanner_test.go,internal/scheduler/scheduler_test.go). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]cmd/probe/main.goby logging errors if the health server fails to shut down cleanly.Pre-commit hooks and code quality:
.pre-commit-config.yamlfile to enforce Go linting withgolangci-lintand to run tests automatically before commits, helping maintain code quality and catch issues early.