Refactor analysis logic into focused modules with macOS separation - #52
Merged
Conversation
This change restructures the analysis layer into smaller, focused files while preserving existing behavior and UI contracts. The main AnalysisLogic type remains the facade used by the view, with file selection, analysis flow, USB handling, lifecycle, and notifications split into dedicated units. macOS-specific analysis responsibilities were moved into a dedicated macOS logic folder and renamed consistently to prepare cleanly for future Linux-specific counterparts without altering runtime rules.
Remove the direct Glass type reference from LiquidGlassCompatibility by selecting glass effects inline per tone, which keeps UI behavior while restoring compatibility on GitHub-hosted runners. Also rename the development workflow/check labels to the requested macUSB - development / Debug Build format for clearer PR status presentation.
Replace glassEffect and glass button style usages in LiquidGlassCompatibility with the existing cross-version fallback styles so the project builds on GitHub-hosted Xcode 16.4 runners.
Roll back the recent CI-specific changes and remove the development debug workflow setup, returning the branch to the previous behavior and documentation alignment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the analysis layer by splitting the previous monolithic implementation into smaller, focused modules with clear responsibilities, including dedicated macOS-specific analysis components. The goal is to improve readability and maintainability while preserving the existing behavior and analysis flow.