This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Add pagination to the account ledgers endpoint#28
Open
egjiri wants to merge 1 commit intoKucoin:masterfrom
Open
Add pagination to the account ledgers endpoint#28egjiri wants to merge 1 commit intoKucoin:masterfrom
egjiri wants to merge 1 commit intoKucoin:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for pagination in the
/api/v1/accounts/ledgersendpoint. I am currently using my fork on my project so I know that this works but ideally we should merge this in to the Kucoin repo and make a new npm release.Note: You might also want to look into which other endpoints are missing pagination and make a similar change to those as well.