Skip to content

feat: add search and status filtering to campaigns list view#277

Open
Sucharitha255 wants to merge 1 commit into
Kuldeeep18:mainfrom
Sucharitha255:feature/campaign-search-filter
Open

feat: add search and status filtering to campaigns list view#277
Sucharitha255 wants to merge 1 commit into
Kuldeeep18:mainfrom
Sucharitha255:feature/campaign-search-filter

Conversation

@Sucharitha255

Copy link
Copy Markdown

Related Issue

Closes #119

Summary

Implemented search and status filtering improvements for the campaigns dashboard.

Changes made

  • Added a status dropdown to the campaigns list view
  • Integrated the status dropdown with the existing filtering system
  • Preserved and improved campaign search functionality
  • Fixed UI duplication issues and cleaned up the header section
  • Verified filtering updates dynamically on the campaigns page

Testing

Tested the following scenarios:

  • Search campaigns by name
  • Filter campaigns by status
  • Combined search and status filtering
  • Verified UI updates correctly

Screenshots

Screenshot 2026-06-15 133613 Screenshot 2026-06-15 133552

@Kuldeeep18

Copy link
Copy Markdown
Owner

Thank you for your contribution! However, after reviewing this PR, we noticed a few critical issues that need to be resolved before it can be merged:

  1. Unresolved Merge Conflict Markers: The PR contains unresolved Git merge conflict markers (<<<<<<< HEAD, =======, >>>>>>>) directly in the codebase, most notably inside <script> blocks in frontend/leads.html and frontend/settings.html. This causes a fatal JavaScript Syntax Error, which breaks the frontend and prevents the application from accepting leads (e.g., via CSV upload).
  2. Contamination with Unrelated Changes: This PR is meant to add search and status filtering to the campaigns list view. However, it currently modifies 10 files with over 1,200 additions. It appears changes from another PR (PR feat(leads): add custom tags and advanced lead filtering #246) and upstream/main were incorrectly merged into this branch, polluting it with unrelated backend changes to models, serializers, and views.

Next Steps:
Please resolve the merge conflicts, remove all <<<<<<< HEAD markers, and clean up your branch so that it only includes the changes relevant to the Campaigns List View. We recommend rebasing against a clean upstream/main branch.

Once the PR is cleaned up and functional, we will be happy to review it again!

@Sucharitha255

Copy link
Copy Markdown
Author

Hi @Kuldeeep18,

Thank you for reviewing the PR.

I rechecked the branch and verified the current state of the PR. It now only contains the changes relevant to the Campaigns List View (frontend/campaigns.html).

I also verified that there are no unresolved merge conflict markers and no unrelated files included in the branch.

Could you please re-review the current state of the PR and let me know if any additional changes are still required?

Thank you!

@Kuldeeep18

Copy link
Copy Markdown
Owner

🚀 PR Guidelines — Read Before Raising a PR

Hey contributors 👋

I’m LeadOrbit's Bot, and I’ll review every PR before it gets merged.

✅ Your PR will only be merged if:

  • The code works correctly and u star the repo
  • There are no unnecessary changes
  • Issues pointed out by CodeRabbit are fixed
  • The PR follows clean coding practices
  • The project structure is maintained

❌ PRs that may be rejected:

  • Copy-paste or AI spam code
  • Unrelated changes
  • Low-quality README edits just for contribution count
  • Ignoring review comments
  • Broken builds or failing checks

Before submitting:

  1. Run and test your code properly
  2. Resolve all CodeRabbit suggestions
  3. Keep your PR focused and clean

And if you find the project useful, consider ⭐ starring the repository — it helps the project grow and motivates further development.

Quality contributions > PR count.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LO-028 [Easy]: Add Search and Status Filtering to Campaigns List View

2 participants