Skip to content

Fix CheckYourself org defaults findings#51

Merged
simongonzalezdc merged 1 commit into
mainfrom
fix/checkyourself-findings
May 29, 2026
Merged

Fix CheckYourself org defaults findings#51
simongonzalezdc merged 1 commit into
mainfrom
fix/checkyourself-findings

Conversation

@simongonzalezdc
Copy link
Copy Markdown
Member

@simongonzalezdc simongonzalezdc commented May 29, 2026

Summary\n- pin GitHub Actions to full commit SHAs and disable checkout credential persistence\n- add this repo's Dependabot config for workflow updates\n- add Python unit tests plus CI coverage for the org agent scripts\n- ignore private key files and Python cache artifacts\n- keep generated Agent Law workflow output pinned too\n\n## Verification\n- python3 -m unittest discover -s tests\n- python3 -m py_compile scripts/check-agent-parity.py scripts/provision-agent-law.py tests/test_agent_defaults.py\n- workflow YAML parse check\n- CheckYourself deep scan: 0 open findings\n- git diff --check


View with Codesmith Autofix with Codesmith
Need help on this PR? Tag @codesmith with what you need. Autofix is disabled.

@simongonzalezdc simongonzalezdc merged commit 3446813 into main May 29, 2026
2 checks passed
@simongonzalezdc simongonzalezdc deleted the fix/checkyourself-findings branch May 29, 2026 20:10
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0e565b0b19

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yml
jobs:
python-tests:
name: Python tests
runs-on: ubuntu-latest
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use the required Blacksmith runner for CI

This newly added CI job runs on ubuntu-latest, but the repository instructions in /workspace/.github/AGENTS.md require CI checks to run on blacksmith-2vcpu-ubuntu-2404. Because this workflow is intended to provide the repo's Python test coverage, it will either fail org policy expectations or leave the new required check running on the wrong runner class; please switch this job to the Blacksmith runner.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant