Fix Unstuck voice input and move live model to GLM-4.5-Air#67
Conversation
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThe PR upgrades the live-demo LLM client from GLM-5.1 to GLM-4.5-Air across configuration, deployment, and tests. It significantly refactors voice dictation in the frontend to preserve draft state, provide a manual keyboard fallback with new helper functions, and improve error handling. Minor rebranding changes the application title and service name from "Unstuck" to "U" in build artifacts. ChangesGLM Model Migration and Voice Input Enhancements
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ec0d1cc3d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| recognition.lang = navigator.language || "en-US"; | ||
| recognition.interimResults = true; | ||
| recognition.continuous = false; | ||
| recognition.continuous = true; |
There was a problem hiding this comment.
Stop continuous recognition when submitting voice text
With continuous = true, the recognizer can keep emitting result events after the user has already pressed Send while the Mic is still active. The submit handler clears message.value but never stops currentRecognition, so a later interim/final result can call applyVoiceTranscript() and put the already-submitted transcript back into the composer (or append more dictated text to the old voiceBaseDraft), making it easy to resend duplicate/stale input. This only affects the voice flow when the user sends before manually tapping Mic again to stop.
Useful? React with 👍 / 👎.
Summary
Verification
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Chores