Fix: PowerShell command action params / PowerShell sensor encoding fix#14
Open
amadeo-alex wants to merge 6 commits intoLAB02-Research:mainfrom
Open
Fix: PowerShell command action params / PowerShell sensor encoding fix#14amadeo-alex wants to merge 6 commits intoLAB02-Research:mainfrom
amadeo-alex wants to merge 6 commits intoLAB02-Research:mainfrom
Conversation
…en payload from HA is "")
This was referenced Sep 4, 2023
Author
|
Regarding the encoding issue reported in LAB02-Research/HASS.Agent#343, at some point a feature should be added which forces the PowerShell processes being spawned to use user-defined encoding. That should allow for usage of any type of characters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
PowerShell Command changes have been tested against following script:
and following scenarios:
In all scenarios the payload value has been properly shown by the popup.
NOTE: due to how parameters are passed, they need to be retrieved with "$PsBoundParameters" instead of "args[]".
In addition this PR also adds an additional precheck in the "HandleActionReceived" function guarding against null payload (it can happen when payload is specified as an empty string ("") in Home Assistant.