Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces Windows-specific functionality to prevent console windows from appearing when spawning cargo subprocesses during model compilation. The change wraps Command::new() calls in a helper function that applies the CREATE_NO_WINDOW flag on Windows platforms, ensuring a cleaner user experience in GUI applications.
- Adds a
new_command()helper function that creates Commands with Windows-specific flags - Replaces all
Command::new("cargo")calls withnew_command("cargo")throughout the build process - Uses conditional compilation to apply the
CREATE_NO_WINDOWflag only on Windows
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
| Branch | silent_windows_runs |
| Testbed | rust-moan |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| Conditional dose modification | 📈 view plot 🚷 view threshold | 1,484.20 ns(-10.09%)Baseline: 1,650.84 ns | 2,178.97 ns (68.11%) |
| Create large dataset (100 subjects) | 📈 view plot 🚷 view threshold | 65,269.00 ns(-4.55%)Baseline: 68,378.56 ns | 74,638.55 ns (87.45%) |
| Data expand complex (1h intervals) | 📈 view plot 🚷 view threshold | 39,241.00 ns(-0.31%)Baseline: 39,362.56 ns | 40,694.81 ns (96.43%) |
| Data expand simple (1h intervals) | 📈 view plot 🚷 view threshold | 691.36 ns(-1.22%)Baseline: 699.90 ns | 733.83 ns (94.21%) |
| Data expand with additional time | 📈 view plot 🚷 view threshold | 54,864.00 ns(-0.08%)Baseline: 54,909.11 ns | 56,309.92 ns (97.43%) |
| Filter exclude subjects | 📈 view plot 🚷 view threshold | 37,796.00 ns(-1.00%)Baseline: 38,177.00 ns | 39,395.78 ns (95.94%) |
| Filter include subjects | 📈 view plot 🚷 view threshold | 10,583.00 ns(+1.37%)Baseline: 10,440.44 ns | 10,906.52 ns (97.03%) |
| Modify all bolus doses | 📈 view plot 🚷 view threshold | 1,406.70 ns(-9.92%)Baseline: 1,561.60 ns | 2,085.63 ns (67.45%) |
| Modify all infusion doses | 📈 view plot 🚷 view threshold | 1,508.40 ns(-8.20%)Baseline: 1,643.19 ns | 2,166.61 ns (69.62%) |
| SubjectBuilder multi-occasion | 📈 view plot 🚷 view threshold | 346.40 ns(-4.35%)Baseline: 362.14 ns | 429.20 ns (80.71%) |
| SubjectBuilder simple | 📈 view plot 🚷 view threshold | 96.00 ns(-7.85%)Baseline: 104.18 ns | 139.48 ns (68.83%) |
| SubjectBuilder with covariates | 📈 view plot 🚷 view threshold | 409.63 ns(-6.13%)Baseline: 436.38 ns | 480.40 ns (85.27%) |
| one_compartment | 📈 view plot 🚷 view threshold | 36,782.00 ns(-13.73%)Baseline: 42,638.17 ns | 56,376.54 ns (65.24%) |
| one_compartment_covariates | 📈 view plot 🚷 view threshold | 43,654.00 ns(-10.28%)Baseline: 48,657.22 ns | 61,084.08 ns (71.47%) |
| readme 20 | 📈 view plot 🚷 view threshold | 556,370.00 ns(-13.70%)Baseline: 644,730.00 ns | 868,540.24 ns (64.06%) |
| two_compartment | 📈 view plot 🚷 view threshold | 37,984.00 ns(-12.86%)Baseline: 43,587.33 ns | 57,342.82 ns (66.24%) |
mhovd
approved these changes
Dec 7, 2025
Collaborator
mhovd
left a comment
There was a problem hiding this comment.
The function name can be improved, even though I don't have any better suggestions myself. But if checks pass then this LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.