ladder: rung 3 -- polls

[Yaraslaut]

What

Rung 3 of the application ladder: polls, anchored on Rallly. Split out of #41 into its own PR, targeting #88's ladder-foundation branch since it depends on the shared testkit/CMake infra there.

Draft until #88 merges — retarget to master and un-draft once it does.

Contents

examples/polls/ in full: PollModel (this ladder's BRIDGE_MODEL_KEY-shared/keyed model), DTOs, entity, schema migration, authorizer, server, Qt/QML GUI, and tests — 40 files.

Includes a fix folded in during review of the combined branch:

• PollModel acquires connections from Lightweight::GlobalDataMapperPool() per execute() call rather than holding one for its own lifetime (WithMapper removed); applyVotes() (a private helper called from within execute() bodies that don't need to share its connection) makes its own independent acquisition.

Verification

Configured and built standalone against the ladder-foundation base with -DMORPH_LADDER_RUNGS=polls (no other rung present). Full suite passes: 557 assertions in 68 test cases (SQLite default). Spec-citation and test-type-name lints clean.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[Copilot]

Pull request overview

Adds “polls” (application ladder rung 3) as a full end-to-end example app: a shared/keyed PollModel backed by SQLite/Lightweight, a standalone server, Qt/QML GUI (including WASM client), and a comprehensive Catch2 test suite exercising shared-instance lifecycle, DTO validation, schema, presenter/bridge wiring, and event polling.

Changes:

• Introduces the polls domain model (PollModel) keyed by pollId, including DTOs, entities, migration, and authorization shape.
• Adds runnable surfaces: standalone server (ladder_polls_server), QML module + GUI adapter layer, and a WASM GUI entry point.
• Adds extensive unit/integration tests covering DB schema, shared-instance behavior, presenter + QML bridge wiring, and GUI smoke loading.

Reviewed changes

Copilot reviewed 40 out of 40 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
examples/polls/CMakeLists.txt	Rung build wiring and WASM server URL define.
examples/polls/gui/qml/Main.qml	Main application shell + landing + navigation.
examples/polls/gui/qml/CreatePollView.qml	Organizer create-poll screen (hand-rolled options editor).
examples/polls/gui/qml/VoteView.qml	Vote screen, schema-driven actions, and live event log display.
examples/polls/gui_lib/poll_forms_controller.hpp	Single shared-handler controller for poll actions + schema allow-list.
examples/polls/gui_lib/poll_forms_controller.cpp	Controller method implementations over one AllowShared handler.
examples/polls/gui_lib/poll_presenter.hpp	Presenter wiring over two handlers (creator + shared/attached handler).
examples/polls/gui_lib/poll_presenter.cpp	Presenter action routing and error reporting.
examples/polls/gui_lib/poll_qml_bridges.hpp	QML-facing adapter (PollBridge) + event poller wiring.
examples/polls/gui_lib/poll_qml_bridges.cpp	DTO↔QVariant conversion + bridge method implementations.
examples/polls/gui_lib/poll_schemas.hpp	Schema JSON for schema-driven actions.
examples/polls/gui_wasm/main_wasm.cpp	WASM client entry: remote context, URL ?poll= parsing, initial props.
examples/polls/include/polls/app/app.hpp	Server-side bootstrap wrapper (RemoteServer + action log + limits).
examples/polls/src/app/app.cpp	App implementation + limit policy + action log lifecycle.
examples/polls/include/polls/auth/polls_authorizer.hpp	Unconditionally permissive authorizer (per rung design).
examples/polls/src/auth/polls_authorizer.cpp	Authorizer hook implementations.
examples/polls/include/polls/core/errors.hpp	Domain exception hierarchy for polls.
examples/polls/include/polls/core/types.hpp	Strong ID types, vote choice enum, and shared constants.
examples/polls/include/polls/db/database.hpp	DB bootstrap API (setup) for production server.
examples/polls/src/db/schema.cpp	Lightweight migration + schema creation.
examples/polls/include/polls/db/poll_entity.hpp	Lightweight entity records (poll/options/votes/comments/history/events).
examples/polls/include/polls/dto/poll_dto.hpp	Poll actions/results DTOs + validation + glaze metadata.
examples/polls/include/polls/dto/vote_dto.hpp	Vote/comment/finalize/undo DTOs + validation helpers.
examples/polls/include/polls/dto/event_dto.hpp	Event log DTOs + cursor validation.
examples/polls/include/polls/models/poll_model.hpp	PollModel public API + bridge registration + keying.
examples/polls/include/polls/units.hpp	Unit system + Count quantity for tallies.
examples/polls/src/server/main.cpp	Standalone server process bootstrap + env config + graceful shutdown.
examples/polls/tests/test_app.cpp	App boot smoke test via simulated remote backend.
examples/polls/tests/test_gui_qml_smoke.cpp	Offscreen QML engine-load smoke tests.
examples/polls/tests/test_poll_dto.cpp	DTO validation + result structure tests.
examples/polls/tests/test_vote_event_dto.cpp	Vote/event DTO validation tests.
examples/polls/tests/test_polls_types.cpp	Strong-id / error-type / constant sanity tests.
examples/polls/tests/test_polls_schema.cpp	Schema migration + entity round-trip + unique index enforcement tests.
examples/polls/tests/test_polls_authorizer.cpp	Authorizer “admits everything” contract tests.
examples/polls/tests/test_poll_presenter.cpp	Presenter action wiring across backend-mode matrix.
examples/polls/tests/test_poll_qml_bridges.cpp	QML-bridge surface and end-to-end adapter wiring tests.
examples/polls/tests/test_shared_instance_lifecycle.cpp	Shared-instance attach/lifetime/poisoning + rate-limit deadline recovery tests.

Suppressed comments (3)

examples/polls/gui/qml/VoteView.qml:204

• Same issue as above: this updates picks on both the checked and unchecked transitions. Only update when checked is true so the selected RadioButton is the one that persists.

                                text: "If need be"
                                enabled: page.state && !page.state.finalized
                                ButtonGroup.group: choiceGroup
                                checked: page.pickFor(optionRow.modelData.id) === "IfNeedBe"
                                onToggled: page.setPick(optionRow.modelData.id, "IfNeedBe")

examples/polls/gui/qml/VoteView.qml:211

• Same issue as above: toggled fires when unchecking too, so this can overwrite the selection after the user picked a different value. Update picks only when the button becomes checked.

                                text: "No"
                                enabled: page.state && !page.state.finalized
                                ButtonGroup.group: choiceGroup
                                checked: page.pickFor(optionRow.modelData.id) === "No"
                                onToggled: page.setPick(optionRow.modelData.id, "No")

examples/polls/include/polls/core/types.hpp:61

• Same documentation issue as OptionId: PollEventId::operator*() cannot be UB — it just returns the stored integer. Adjust the comment to match the real contract (0 means “not entered”; check hasValue() when needed).

    /// @brief Unchecked access to the engaged value (UB when empty, exactly
    ///        like `std::optional::operator*`).
    /// @return The engaged value.
    [[nodiscard]] constexpr std::int64_t operator*() const { return value; }

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.