Merged
Conversation
the torchrun-hpc trampoline.
tbennun
approved these changes
Sep 29, 2025
Collaborator
tbennun
left a comment
tbennun
left a comment
There was a problem hiding this comment.
This assumes we will always use one device per process?
|
@tbennun Yeah, we were discussing that this would be a good default setting. If anyone would like to do multi-GPU per process, they could set it post initialization. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the device_id initialization to the init_process_group call in
the torchrun-hpc trampoline.