Provide Toggle for PyTorch Distributed Initialization#62
Closed
michaelmckinsey1 wants to merge 1 commit intoLBANN:mainfrom
Closed
Provide Toggle for PyTorch Distributed Initialization#62michaelmckinsey1 wants to merge 1 commit intoLBANN:mainfrom
michaelmckinsey1 wants to merge 1 commit intoLBANN:mainfrom
Conversation
5 tasks
Collaborator
|
@michaelmckinsey1 @PatrickRMiles Hmmm, not sure that this is the path that I would suggest. Let's plan to talk about it tomorrow. |
Contributor
Author
|
We are quite certain that we won't merge this, so I can leave it as a draft until I find a better solution. |
Contributor
Author
|
Original issue that made this feature necessary is fixed by using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Provide a flag to not invoke
torch.dist.init_process_group()if the user needs to instead invoke this in their application.Use case
With LBANN/ScaFFold#17, importing
mpi4pyafter Torch Distributed is initialized causes a segmentation fault. By disablingdist.init_process_group()in the trampoline, ScaFFold can usempi4pybefore initializing Torch Distributed within the benchmark. So this flag is used to keepmpi4pyandtorch.distseparate, in this case.