ci: pin GitHub Actions to commit SHAs (11)#79
Open
mirkosalvato1-ctrl wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reduces GitHub Actions supply-chain risk by pinning third-party Actions previously referenced by mutable tags (e.g., @v3, @v5, @v2) to full commit SHAs, while preserving the original tag as an inline comment for readability/auditing.
Changes:
- Pinned
pnpm/action-setupto a full commit SHA in the E2E system test workflow. - Pinned Docker build-related Actions (
setup-buildx,login,build-push) to full commit SHAs across server/frontend/AI image build workflows. - Pinned
softprops/action-gh-releaseto a full commit SHA in the CLI release workflow.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/e2e-system-tests.yml | Pins pnpm/action-setup to a commit SHA while retaining the v3 marker as a comment. |
| .github/workflows/docker-build-push-server.yml | Pins Docker Buildx/Login/Build-Push Actions to commit SHAs for server image publishing. |
| .github/workflows/docker-build-push-frontend.yml | Pins Docker Buildx/Login/Build-Push Actions to commit SHAs for frontend image publishing. |
| .github/workflows/docker-build-push-ai.yml | Pins Docker Buildx/Login/Build-Push Actions to commit SHAs for AI image publishing (matrix builds). |
| .github/workflows/build-publish-cli.yml | Pins softprops/action-gh-release to a commit SHA for release creation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Mutable Action tags (
@v4,@main) can be retagged, which is a supply-chain risk.This PR pins third-party Actions to full commit SHAs while keeping the tag in a comment.
Official
actions/*tags are left unchanged (common maintainer preference).Pins
softprops/action-gh-release@v2 -> 3bb12739c298docker/setup-buildx-action@v3 -> 8d2750c68a42docker/login-action@v3 -> c94ce9fb4685docker/build-push-action@v5 -> ca052bb54ab0docker/setup-buildx-action@v3 -> 8d2750c68a42docker/login-action@v3 -> c94ce9fb4685docker/build-push-action@v5 -> ca052bb54ab0docker/setup-buildx-action@v3 -> 8d2750c68a42docker/login-action@v3 -> c94ce9fb4685docker/build-push-action@v5 -> ca052bb54ab0pnpm/action-setup@v3 -> a3252b78c470Reference: GitHub docs on using third-party actions securely.