Added a check to see if the public date is included in the shipper so we don't override it#437
Merged
Added a check to see if the public date is included in the shipper so we don't override it#437
Conversation
… we don't override it
cmccully
requested review from
Copilot,
drhaz,
emannenicholas,
jchate6 and
markBowman
There was a problem hiding this comment.
Pull request overview
This PR adds functionality to set the public date from external metadata in the shipper message, preventing it from being overridden during processing. This is part of version 1.29.0.
Changes:
- Added logic to check for and set public_date from file_info message during frame opening
- Bumped version from 1.28.0 to 1.29.0
- Updated changelog with release notes
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pyproject.toml | Version bump to 1.29.0 |
| banzai/lco.py | Added public_date initialization from file_info and minor formatting improvement |
| CHANGES.md | Added release notes for version 1.29.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
This closes #437 |
jchate6
approved these changes
Feb 24, 2026
Collaborator
jchate6
left a comment
jchate6
left a comment
There was a problem hiding this comment.
Looks great, sorry I didn't get to this sooner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.