Bugfix/syncing targets race condition#32
Open
crpellegrino wants to merge 3 commits intoLCOGT:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a potential race condition when a new
Targetis added to SNEx1 while thesync_databases.pyscript is running. In the past this has thrown exceptions when the script attempts to sync a newly-createdTargetNameto aTargetthat is not yet in the SNEx2 database.To fix this issue, the script now checks whether the associated
Targetobject exists in the SNEx2 database before ingesting a newTargetName. If not found, the script will create theTargetbefore continuing to sync associated name and extra values.These changes should be ready to merge--let me know when they are and I'll keep an eye on the syncing process just to be sure everything is working as intended.