Skip to content

GH-5: Write a script to find websites based off of body names#7

Open
zaeema-n wants to merge 12 commits into
LDFLK:mainfrom
zaeema-n:find-domains
Open

GH-5: Write a script to find websites based off of body names#7
zaeema-n wants to merge 12 commits into
LDFLK:mainfrom
zaeema-n:find-domains

Conversation

@zaeema-n

Copy link
Copy Markdown
Member

This pr closes #5

@zaeema-n
zaeema-n requested a review from ChanukaUOJ June 24, 2026 09:23

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new resolve command to the CLI, allowing users to look up official domains from institution names via web search before scanning. Key feedback includes removing debug print statements that corrupt the rich.progress UI, caching suffix normalization to optimize performance in hot loops, using a cleaner dictionary-based approach in the thread pool runner to avoid type ignores, and supporting fractional timeouts by preserving float values instead of truncating them to integers.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/websitescorecard/resolve/domain_search.py Outdated
Comment thread src/websitescorecard/resolve/domain_search.py
Comment thread src/websitescorecard/resolve/resolve_runner.py Outdated
Comment thread src/websitescorecard/cli.py Outdated
Comment thread src/websitescorecard/resolve/resolve_runner.py Outdated
Comment thread src/websitescorecard/resolve/domain_search.py Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NethmikaKekuu NethmikaKekuu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Write a script to find websites based off of body names

2 participants