feat: refactor gogen to use bytecode#1965
Merged
Merged
Conversation
DavePearce
force-pushed
the
1963-feat-refactor-gogen-to-use-bytecode
branch
2 times, most recently
from
ca3e416 to
26a1bdb
Compare
This updates the GoGenerator (GoGen) to use the new Bytecode API inplace of the legacy WordMachine API. Some changes were required for first. Firstly, proper support for "subtract with borrow" semantics was put in place. Secondly, support for the bytecode CheckCast instruction was added. NOTE: this also fixes the Program.MaxStaticDepth() function which was returning incorrect results. Signed-off-by: DavePearce <dave01001110@gmail.com>
DavePearce
force-pushed
the
1963-feat-refactor-gogen-to-use-bytecode
branch
from
26a1bdb to
e4ec1f6
Compare
letypequividelespoubelles
approved these changes
Jul 7, 2026
| // UintAdd constructs an addition instruction computing | ||
| // LoadConst constructs an instruction assigning a constant into a single | ||
| // target register. | ||
| func LoadConst[W Word[W]](target RegisterId, constant W) Bytecode[W] { |
Contributor
There was a problem hiding this comment.
Well ... We'll have to uodate this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the GoGenerator to use the new Bytecode API rather than the legacy WordMachine API. In addition, GoGen is tweaked to support the "subtract with borrow" semantics.