feat: update range proof of u1 registers#1967
Open
letypequividelespoubelles wants to merge 2 commits into
Open
feat: update range proof of u1 registers#1967letypequividelespoubelles wants to merge 2 commits into
letypequividelespoubelles wants to merge 2 commits into
Conversation
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates how 1-bit (u1) registers are range-proven in the ZkC pipeline, moving them away from static range tables toward booleanity constraints in the MIR constraint layer.
Changes:
- Skip static range-table proof for width==1 registers and instead add a booleanity vanishing constraint (
r*r == r) for u1 registers during constraint generation. - Adjust VM-side range module width discovery to stop explicitly seeding/including width==1 (intended to avoid generating/using $range_u1 tables).
- Minor comment cleanup around range-width selection.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/zkc/vm/internal/transform/range_constraints.go | Changes which register widths are considered “needed” for generating range modules (notably width 1). |
| pkg/zkc/constraints/range_lookup.go | Adds booleanity constraints for u1 registers instead of using static range-table lookups. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+142
to
+144
| // Note: width == 0 comes from native registers, which are not range-checked. | ||
| // width == 1 are not range proven with a call to a static table, but with a constraint r (1 - r) == 0 | ||
| if w != 0 && w != 1 && !seen[w] { |
Signed-off-by: F Bojarski <ceciestunepoubelle@protonmail.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.