fix: validate threshold DKG input parameters#176
Open
PROWLERx15 wants to merge 1 commit intoLFDT-Lockness:cggmp24/mfrom
Open
fix: validate threshold DKG input parameters#176PROWLERx15 wants to merge 1 commit intoLFDT-Lockness:cggmp24/mfrom
PROWLERx15 wants to merge 1 commit intoLFDT-Lockness:cggmp24/mfrom
Conversation
Signed-off-by: PROWLERx15 <prowlerx15@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39
run_threshold_keygendid not checkt,n, oriup front. Badvalues like
t > nwould run the full protocol and fail later withunclear errors deep in ZK proofs or share validation.
Added upfront checks at the start of
run_threshold_keygen:n < 2→ TooFewPartiest < 2→ ThresholdTooSmallt > n→ ThresholdTooLargei >= n→ PartyIndexOutOfRangeAll return
KeygenErrorvia newBugvariants immediately, before anynetworking or computation.
Tests (all curves):
t_greater_than_nt=5, n=3 → errort_too_smallt=1, n=3 → errorn_too_smallt=2, n=1 → errori_out_of_rangei=3, n=3 → error